Skip to content

Update EmitAllViewModel.kt #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update EmitAllViewModel.kt #1

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2cbf68
Update EmitAllViewModel.kt
aliakberaakashdh Jul 5, 2023
f5a5809
Update EmitAllViewModel.kt
aliakberaakashdh Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...c/main/java/me/amitshekhar/learn/kotlin/flow/ui/errorhandling/emitall/EmitAllViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class EmitAllViewModel(
emitAll(flowOf(emptyList()))
}.zip(apiHelper.getUsersWithError().catch {
emitAll(flowOf(emptyList()))
}) { usersFromApi, moreUsersFromApi ->
}) { usersFromApi, usersFromErrorApi ->
val allUsersFromApi = mutableListOf<ApiUser>()
allUsersFromApi.addAll(usersFromApi)
allUsersFromApi.addAll(moreUsersFromApi)
Copy link

@mohityadav7 mohityadav7 Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still using old variable name moreUsersFromApi in line 37:

allUsersFromApi.addAll(moreUsersFromApi)

Copy link
Author

@aliakberaakashdh aliakberaakashdh Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated @mohityadav7

Expand All @@ -44,4 +44,4 @@ class EmitAllViewModel(
}
}

}
}