Add support for ADMX100X on ZedBoard #1954
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BCapota
requested review from
AndreiGrozav,
IuliaCMoldovan,
LBFFilho,
PopPaul2021,
StancaPop,
gastmaier and
sarpadi
as code owners
Contributor
There was a problem hiding this comment.
Maybe it shouldn't be added since it's just empty
| @@ -0,0 +1,16 @@ | |||
| ############################################################################### | |||
| ## Copyright (C) 2014-2025 Analog Devices, Inc. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| ## Copyright (C) 2014-2025 Analog Devices, Inc. All rights reserved. | |
| ## Copyright (C) 2025 Analog Devices, Inc. All rights reserved. |
And the same should be done for all files (except Makefiles)
| set_property -dict {IOSTANDARD LVCMOS33} [get_ports gpio_bd[29]] ; ## XADC-GIO2 | ||
| set_property -dict {IOSTANDARD LVCMOS33} [get_ports gpio_bd[30]] ; ## XADC-GIO3 | ||
|
|
||
| set_property -dict {IOSTANDARD LVCMOS33} [get_ports gpio_bd[31]] ; ## OTG-RESETN No newline at end of file |
| "system_top.v"] | ||
|
|
||
| adi_project_run admx100x_evb_zed | ||
|
|
BCapota
force-pushed
the
admx100x_v1
branch
2 times, most recently
from
6900eaf to
d0b4b3e
Compare
Signed-off-by: Capota Bianca <bianca-ramona.capota@analog.com>
PopPaul2021
requested changes
Nov 24, 2025
docs/projects/admx100x_evb/index.rst
Outdated
| - CS_FPGA | ||
| - 0 | ||
| * - PS | ||
| - SPI 1 |
Contributor
There was a problem hiding this comment.
The CS_DAC is connected to SPI 0 instead of SPI 1.
docs/projects/admx100x_evb/index.rst
Outdated
| - Source code link | ||
| - Documentation link | ||
| * - AXI_AD777x | ||
| - :git-hdl:`library/axi_ad777x` |
Contributor
There was a problem hiding this comment.
axi_ad777x can be removed from this list.
|
|
||
| // gpio assign | ||
|
|
||
| assign admx100x_sync_mode = gpio_o[34]; |
Contributor
There was a problem hiding this comment.
Can we arrange the assignments in numerical order?
Signed-off-by: Capota Bianca <bianca-ramona.capota@analog.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds the following:
PR Type
PR Checklist