deny on allow_attributes lint in physical-plan

[YuraLitvinov]

Which issue does this PR close?

• Part of New lint clippy::allow_attributes #18881.

What changes are included in this PR?

Deny attribute for allow_attrbute lint on physical-plan, this allows it to not be applied on imported crates, also, a few of the functions no longer required their respective lints, such as too_many_arguments, hence, I had them removed.

Are these changes tested?

I've ran the entire clippy suite before creating a PR.

Are there any user-facing changes?

There weren't any user-facing changes

[Jefffrey]

Thanks for picking this up

[Jefffrey]

Can we place these on the fields themselves instead of the struct, to make it clear its the fields that are unused?

[Jefffrey]

I meant like this:

pub struct Coordinate {
    /// Horizontal position in the tree
    #[expect(dead_code)]
    pub x: usize,
    /// Vertical position in the tree
    #[expect(dead_code)]
    pub y: usize,
}

[Jefffrey]

Suggested change

	#[expect(unused)]
	#[expect(dead_code)]

[Jefffrey]

Unrelated to this PR, but @2010YOUY01 were we supposed to remove these denys for needless_pass_by_value in each of the lib.rs as part of #18904?

(Doesn't need to be addressed by this PR, just something it made it realize)

Edit: raised #18996

[YuraLitvinov]

@Jefffrey Hi, thank you for feedback. How about I do another crate too and let it be physical-expr, so we can just pack each PR more densely with changes?

[Jefffrey]

Hi, thank you for feedback. How about I do another crate too and let it be physical-expr, so we can just pack each PR more densely with changes?

Yes I'm fine with including physical-expr changes as long as they aren't too massive on their own

[alamb]

Looks great to me too -- thanks @YuraLitvinov and @Jefffrey

It looks like all the outstanding comments were addressed so I'll merge this one in. If there are other changes we want to make, let's do them in follow on PRs