-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-17834. Fix invalid HTTP links for DataNodes in IPv6 environment #8097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
@steveloughran please fix you HADOOP-19696 ,the word "License" which was misspelled as "Li2cense" in the |
|
ooh, let me do that asap as a followup. (actually, looks like this typo was in two other assembly xml files, I'd just copied it over from them. will fix everywhere) |
|
@hadoop-yetus rebuild |
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NOTICE
This is a backport of HDFS-17834 from branch-3.4 to trunk.
What changes were proposed in this pull request?
This PR fixes HDFS-17834: HDFS Router Federation Health page generates invalid HTTP links for DataNodes in IPv6 environment.
Problem
The Router Federation Health page incorrectly handles IPv6 addresses when constructing DataNode HTTP links:
infoAddrandinfoSecureAddrfieldsSolution
[address]:portExample
Before:
https://fe80:0:0:0:215:5dff:fe00:3110:50075(invalid)After:
https://[fe80:0:0:0:215:5dff:fe00:3110]:50075(valid)How was this patch tested?
Code Change Verification
Original PR
This change was already committed and tested in branch-3.4.
Please review @slfan1989 @Hexiaoqiao