HDFS-17858. Fix TestDFSAdmin#testAllDatanodesReconfig fails #8107
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushtkn
reviewed
Nov 27, 2025
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
Outdated
Show resolved
Hide resolved
lfxy
force-pushed
the
feature/HDFS-17858
branch
from
39e81f4 to
4aba428
Compare
ayushtkn
reviewed
Nov 30, 2025
Comment on lines
1252
to
1265
| LambdaTestUtils.await(1000, 50, () -> { | ||
| int result = admin.startReconfiguration("datanode", "livenodes"); | ||
| assertThat(result).isEqualTo(0); | ||
| final List<String> outs = new ArrayList<>(); | ||
| final List<String> errs = new ArrayList<>(); | ||
| awaitReconfigurationFinished("datanode", "livenodes", outs, errs); | ||
| return errs.isEmpty(); | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
in this logic we are doing admin.startReconfiguration("datanode", "livenodes"); like in every iteration, we should just wait for the result and not perform any action, that changes the flow of the test
Contributor
Author
There was a problem hiding this comment.
We cannot determine whether the reconfiguration has finished based on the return value of admin.startReconfiguration(), because even if it returns 0, the datanode's reconfig thread may not have finished. We need to actively get the reconfiguration status using getReconfigurationStatus, to wait reconfiguration finished.
Contributor
Author
There was a problem hiding this comment.
I have replaced awaitReconfigurationFinished() with getReconfigurationStatus().
lfxy
force-pushed
the
feature/HDFS-17858
branch
from
4aba428 to
72de13a
Compare
|
💔 -1 overall
This message was automatically generated. |
lfxy
force-pushed
the
feature/HDFS-17858
branch
from
72de13a to
a26cc18
Compare
|
💔 -1 overall
This message was automatically generated. |
lfxy
force-pushed
the
feature/HDFS-17858
branch
from
a26cc18 to
bdd537b
Compare
|
💔 -1 overall
This message was automatically generated. |
lfxy
force-pushed
the
feature/HDFS-17858
branch
from
bdd537b to
25d5571
Compare
|
💔 -1 overall
This message was automatically generated. |
lfxy
commented
Dec 4, 2025
| } | ||
| return !outs.isEmpty() && outs.get(0).contains("finished"); | ||
| }); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@ayushtkn The test has passed. Do you agree with this modification? Also, is it possible to replace LambdaTestUtils.await() with awaitReconfigurationFinished(), since their logic is the same?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestDFSAdmin::testAllDatanodesReconfig() always failed because the last startReconfiguration() need some time to finish.