Skip to content

Handle failed tomcat war deployment (status OK but body FAIL) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Handle failed tomcat war deployment (status OK but body FAIL) #27

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
153af9a
handle failed tomcat war deployment
May 24, 2017
e13cd3b
sorry, fix the }
May 24, 2017
10efcd8
space before :
May 24, 2017
bf249b3
space before :
May 24, 2017
ef71179
space before : (+3 squashed commits)
May 24, 2017
5259d16
Merge branch 'trunk' of https://github.com/laurentperez/tomcat-maven-…
May 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ven-plugin/src/main/resources/org/apache/tomcat/maven/common/messages/messages.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,5 @@ ReloadMojo.reloadingApp = Reloading application at {0}
#

tomcatHttpStatusError = Tomcat return http status error: {0}, Reason Phrase: {1}
tomcatHttpDeployBodyError = FAIL
tomcatHttpBodyError = Tomcat return http body error: {0}
4 changes: 3 additions & 1 deletion ...-plugin/src/main/resources/org/apache/tomcat/maven/common/messages/messages_fr.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,6 @@ UndeployMojo.undeployError = N'a pas pu retirer l'application : {0}

ReloadMojo.reloadingApp = Rechargement de l'application sur {0}

tomcatHttpStatusError = Tomcat a retourn\u00E9 un code HTTP en erreur: {0}, raison: {1}
tomcatHttpStatusError = Tomcat a retourn\u00E9 un code HTTP en erreur: {0}, raison: {1}
Copy link
Member

@michael-o michael-o May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that wrong? As far as I know French always puts a space before the colon.

Copy link
Author

@laurentperez laurentperez May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. I just added the space.

tomcatHttpDeployBodyError = ECHEC
tomcatHttpBodyError = Tomcat a retourn\u00E9 un corps HTTP en erreur: {0}
9 changes: 8 additions & 1 deletion ...-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractI18NTomcat6Mojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,13 @@ protected void checkTomcatResponse( TomcatManagerResponse tomcatResponse )
messagesProvider.getMessage( "tomcatHttpStatusError", statusCode,
tomcatResponse.getReasonPhrase() ) + ": "
+ tomcatResponse.getHttpResponseBody() );
}
} else if(tomcatResponse.getHttpResponseBody().startsWith(messagesProvider.getMessage("tomcatHttpDeployBodyError"))) {
{
getLog().error( messagesProvider.getMessage( "tomcatHttpBodyError",
tomcatResponse.getHttpResponseBody() ) );
throw new MojoExecutionException(
messagesProvider.getMessage( "tomcatHttpBodyError",
tomcatResponse.getHttpResponseBody() ));
}
}
}
8 changes: 8 additions & 0 deletions ...aven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/AbstractTomcat7Mojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ protected void checkTomcatResponse( TomcatManagerResponse tomcatResponse )
messagesProvider.getMessage( "tomcatHttpStatusError", statusCode,
tomcatResponse.getReasonPhrase() ) + ": "
+ tomcatResponse.getHttpResponseBody() );
} else if(tomcatResponse.getHttpResponseBody().startsWith(messagesProvider.getMessage("tomcatHttpDeployBodyError"))) {
{
getLog().error( messagesProvider.getMessage( "tomcatHttpBodyError",
tomcatResponse.getHttpResponseBody() ) );
throw new MojoExecutionException(
messagesProvider.getMessage( "tomcatHttpBodyError",
tomcatResponse.getHttpResponseBody() ));
}
}
}
}
9 changes: 8 additions & 1 deletion ...aven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat8/AbstractTomcat8Mojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ protected void checkTomcatResponse( TomcatManagerResponse tomcatResponse )
messagesProvider.getMessage( "tomcatHttpStatusError", statusCode,
tomcatResponse.getReasonPhrase() ) + ": "
+ tomcatResponse.getHttpResponseBody() );
}
} else if(tomcatResponse.getHttpResponseBody().startsWith(messagesProvider.getMessage("tomcatHttpDeployBodyError"))) {
{
getLog().error( messagesProvider.getMessage( "tomcatHttpBodyError",
tomcatResponse.getHttpResponseBody() ) );
throw new MojoExecutionException(
messagesProvider.getMessage( "tomcatHttpBodyError",
tomcatResponse.getHttpResponseBody() ));
}
}
}