Skip to content

Don't upload multiple times to same artifact in sketch compilation workflow #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Don't upload multiple times to same artifact in sketch compilation workflow #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/compile-examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ on:

env:
SKETCHES_REPORTS_PATH: sketches-reports
SKETCHES_REPORTS_ARTIFACT_NAME: sketches-reports

jobs:
build:
Expand All @@ -39,14 +38,23 @@ jobs:
matrix:
board:
- fqbn: arduino:mbed_portenta:envie_m7
artifact-name-suffix: arduino-mbed_portenta-envie_m7
- fqbn: arduino:mbed_nano:nanorp2040connect
artifact-name-suffix: arduino-mbed__nano-nanorp2040connect
- fqbn: arduino:mbed_nicla:nicla_vision
artifact-name-suffix: arduino-mbed_nicla-nicla_vision
- fqbn: arduino:mbed_nicla:nicla_sense
artifact-name-suffix: arduino-mbed_nicla-nicla_sense
- fqbn: arduino:mbed_nano:nano33ble
artifact-name-suffix: arduino-mbed_nano-nano33ble
- fqbn: arduino:renesas_portenta:portenta_c33
artifact-name-suffix: arduino-renesas_portenta-portenta_c33
- fqbn: arduino:renesas_uno:unor4wifi
artifact-name-suffix: arduino-renesas_uno-unor4wifi
- fqbn: arduino:samd:mkrwifi1010
artifact-name-suffix: arduino-samd-mkrwifi1010
- fqbn: arduino:esp32:nano_nora
artifact-name-suffix: arduino-esp32-nano_nora

steps:
- name: Checkout repository
Expand All @@ -66,7 +74,7 @@ jobs:
with:
if-no-files-found: error
path: ${{ env.SKETCHES_REPORTS_PATH }}
name: ${{ env.SKETCHES_REPORTS_ARTIFACT_NAME }}
name: sketches-report-${{ matrix.board.artifact-name-suffix }}

report-size-deltas:
needs: build
Expand All @@ -82,12 +90,11 @@ jobs:
continue-on-error: true # If compilation failed for all boards then there are no artifacts
uses: actions/download-artifact@v4
with:
name: ${{ env.SKETCHES_REPORTS_ARTIFACT_NAME }}
path: ${{ env.SKETCHES_REPORTS_PATH }}

- name: Comment size deltas report to PR
uses: arduino/report-size-deltas@v1
# If actions/download-artifact failed, there are no artifacts to report from.
if: steps.download-artifact.outcome == 'success'
with:
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}
Loading