Skip to content

test(internal/orchestrator/app): add unit test for the app #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2025
Merged

test(internal/orchestrator/app): add unit test for the app #23

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea06b5e
fix(app): improve error messages for invalid app paths in Load function
dido18 Oct 24, 2025
c60ecc1
fix(tests): improve test descriptions and error messages in TestLoad
dido18 Oct 24, 2025
094b60f
Update internal/orchestrator/app/app_test.go
dido18 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/orchestrator/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func Load(appPath string) (ArduinoApp, error) {
return ArduinoApp{}, fmt.Errorf("app path is not valid: %w", err)
}
if !exist {
return ArduinoApp{}, fmt.Errorf("no such file or directory: %s", path)
return ArduinoApp{}, fmt.Errorf("app path must be a directory: %s", path)
}
path, err = path.Abs()
if err != nil {
Expand Down
17 changes: 15 additions & 2 deletions internal/orchestrator/app/app_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,26 @@ import (
)

func TestLoad(t *testing.T) {
t.Run("empty", func(t *testing.T) {
t.Run("it fails if tha app path is empty", func(t *testing.T) {
app, err := Load("")
assert.Error(t, err)
assert.Empty(t, app)
assert.Contains(t, err.Error(), "empty app path")
})

t.Run("AppSimple", func(t *testing.T) {
t.Run("it fails if the app path exist but it's a file", func(t *testing.T) {
_, err := Load("testdata/app.yaml")
assert.Error(t, err)
assert.Contains(t, err.Error(), "app path must be a directory")
})

t.Run("it fails if the app path does not exist", func(t *testing.T) {
_, err := Load("testdata/this-folder-does-not-exist")
assert.Error(t, err)
assert.Contains(t, err.Error(), "app path is not valid")
})

t.Run("it loads an app correctly", func(t *testing.T) {
app, err := Load("testdata/AppSimple")
assert.NoError(t, err)
assert.NotEmpty(t, app)
Expand Down