fix(pkg/board): handle adb connection error #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirkoCrobu
reviewed
Nov 24, 2025
dido18
requested changes
Nov 25, 2025
giulio93
reviewed
Nov 25, 2025
| } | ||
| if err := cmd.Run(); err != nil { | ||
| return nil, fmt.Errorf("failed to connect to ADB host %s: %w", host, err) | ||
| if out, err := cmd.RunAndCaptureCombinedOutput(context.TODO()); err != nil { |
Contributor
There was a problem hiding this comment.
Why not context.Background()?
Contributor
Author
There was a problem hiding this comment.
that's exactly the same, but TODO, remember to add it in the future.
dido18
approved these changes
Nov 25, 2025
Contributor
dido18
left a comment
dido18
left a comment
There was a problem hiding this comment.
Only for reference, the other possible states of the get-state are the following:
adb get-state print offline | bootloader | device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should check if the board is connected before returning an ADBConnetion object.
Change description
Use
adb get-statefor checking if the board is there and it is connected.Additional Notes
Reviewer checklist
main.