missing engine is not a cause for panic #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If engine is missing, assume that the user still wants to rotate the secret. If the user deliberatly tries to connect to a non-postgres database, the right place to fail is in the db.connect() call.
adithyasolai
added
triage/needs-investigation
and removed
triage/needs-investigation
labels
Contributor
|
The existing approach and the one suggested in this pull request seem pretty much equivalent to me. What's the advantage of doing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If engine is missing, assume that the user still wants to rotate the secret.
If the user deliberatly tries to connect to a non-postgres database,
the right place to fail is in the db.connect() call.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.