Fixed <think> </think> tags for GPT-OSS in bedrock.py #200
+31
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added handling for message and content block deltas, including safety checks for open thinking tags. Results in working reasoning and makes GPT-OSS 80/120b usable in frontends that expect closing thinking tags.
|
@zxkane This is blocking our work as well. Would you mind taking a look at this PR? |
zxkane
approved these changes
Nov 20, 2025
Member
|
Hi @user-error1 , Great work on your first PR! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling for message and content block deltas, including safety checks for open thinking tags.
Results in working reasoning and makes GPT-OSS 80/120b usable in frontends that expect closing thinking tags.
Issue #, if available: #194
Description of changes:
Detects the transition from reasoning content to regular text content and automatically closes the tag. Keepis signature support for models like Claude/DeepSeek that send a signature field. Added a safety check at messageStop to ensure any unclosed tags are properly closed before the stream ends.
This results in working GPT-OSS thinking tags and works well in a frontend like open webui.
p.s. this is my first PR / open source contribution ever and it feels AWESOME! :)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.