Skip to content

Conversation

@DominicWatts
Copy link
Contributor

I installed in a multi-container environment and the tmp var was not mounted and therefore was not shared between containers. I recommend that you allow the path of the json files to be configurable.

Also I took the time to create github actions based on your Makefile. Easier to test code submissions.

@DominicWatts
Copy link
Contributor Author

@DominicWatts
Copy link
Contributor Author

I've put some keys in the actions - so they are publicly visible. However you can use github secrets

https://github.com/DominicWatts/Faker/blob/master/.github/workflows/phpstan.yml#L10

- uses: MilesChou/composer-action@master
      env:
        COMPOSER_AUTH: ${{secrets.COMPOSER_AUTH}}
      with:

But that needs configuring in each repo

Anyway, worse case scenario I hope you consider the introduction of a configurable path.

@hostep
Copy link
Member

hostep commented Aug 23, 2021

Thanks @DominicWatts!

Will try to have a proper look in one of the next few weeks. But first remark would be if you could split the PR into two parts, where the new functionality is added in one PR, and the github actions are in a second PR.

@DominicWatts
Copy link
Contributor Author

No probs - created two PRs

#28

#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants