Skip to content

test: move settings to settings_test.conf #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

test: move settings to settings_test.conf #249

wants to merge 7 commits into from

Conversation

@sugh01
Copy link
Collaborator

@sugh01 sugh01 commented Dec 1, 2025

No description provided.

oskarszoon
oskarszoon requested changes Dec 1, 2025
View reviewed changes
@sugh01 sugh01 marked this pull request as ready for review December 3, 2025 14:01
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sugh01 sugh01 requested a review from oskarszoon December 3, 2025 14:02
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025 •
edited
Loading

🤖 Claude Code Review

Status: Complete

Summary:
This PR moves test-specific settings from settings_local.conf to settings_test.conf to better organize test configuration. The changes affect Docker Compose files, the Makefile, and numerous test files.

Findings:

  • ✅ Trailing space issue after settings_test.conf (mentioned in existing comment) appears to have been fixed in the latest commit
  • ✅ Consistent replacement pattern across all Docker Compose files
  • ✅ Test files correctly updated to remove SETTINGS_CONTEXT environment variable usage
  • ✅ New settings_test.conf file contains appropriate test-specific configuration

No remaining issues found. The changes are systematic and consistent throughout the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oskarszoon oskarszoon oskarszoon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sugh01 @oskarszoon