Add support for metadata.code.call_targets section #4664
Conversation
Lukasdoe
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
| hint = hint->next; | ||
| } | ||
| if (hint != NULL) { | ||
| ((struct WASMCompilationHintBranchHint *)hint)->used = true; |
There was a problem hiding this comment.
no need to cast as the used field is in WASMCompilationHint as well.
| uint64_t | ||
| aot_func_name_hash(const char *name) | ||
| { | ||
| return MD5Hash(StringRef(name)); |
There was a problem hiding this comment.
is this function ubiquitously available?
i suspect it isn't.
There was a problem hiding this comment.
Can you please elaborate a bit more on that? I don't understand what your concern is, since I'm not sure whether you are hinting at the availability of the MD5Hash function, which is part of LLVM's MD5.h support header, or something else.
| struct WASMCompilationHint *next; | ||
| enum WASMCompilationHintType type; | ||
| uint32 offset; | ||
| bool used; |
There was a problem hiding this comment.
is this used field only for diagnostic purposes?
There was a problem hiding this comment.
more or less. It is definitely a hint that something is wrong if a hint is not used. We apply hints to all branch instructions, so if it is not used, we either missed it, or the referenced instruction does not exist (meaning an invalid compilation hint section).
However, since these hints are not mission-critical, I didn't want to assert that this is true.
2 participants
Following #4460, I also implemented call targets hints in WAMR. Support in LLVM is tbd.
This also includes the generalization of our metadata parsing mechanism so that it'll be very easy to integrate new types of compilation metadata.
Basis: https://github.com/WebAssembly/compilation-hints/blob/main/proposals/compilation-hints/Overview.md