Skip to content

Commit dba0b79

Browse files
Assem-UberadhityamamallanmacrotimCopilot
authored
feat: Use grouper in history page (#1091)
* Create fetcher utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename query Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add configurable throttleMs to the hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use fetcher in workflow history * remove useKeepLoadingEvents Signed-off-by: Assem Hafez <assem.hafez@uber.com> * grouping utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * change the api of onChange and add destroy method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * replace getGroups with getState Signed-off-by: Assem Hafez <assem.hafez@uber.com> * init grouper hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * user grouper in history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update fetcher based on feedback Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename unmout to destroy Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move condition into executeImmediately Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update destroy in method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * mock grouper throttle Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix use fetcher test case Signed-off-by: Assem Hafez <assem.hafez@uber.com> * feat: Grouped events table header (#1059) * Grouped events header Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix comment typo Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add space for reset button Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move grouped table Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history-v2/workflow-history-grouped-table/workflow-history-grouped-table.tsx Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com> * Change Id to ID Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com> * chore: Fixed docker URI for kafka image (#1066) Signed-off-by: Tim Chan <tim.chan@uber.com> * chore: New feature flag for Cron List View (#1068) Signed-off-by: Tim Chan <tim.chan@uber.com> * use fetcher in workflow history * fix content clicks Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix use initial selected event Signed-off-by: Assem Hafez <assem.hafez@uber.com> * increase page size Signed-off-by: Assem Hafez <assem.hafez@uber.com> * optimize first page processing Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix: History content negative z-index disallow clicks (#1069) * fix content clicks Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history/workflow-history.styles.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: Use fetcher in workflow history (#1064) * Create fetcher utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename query Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * add configurable throttleMs to the hook Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use fetcher in workflow history * remove useKeepLoadingEvents Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update fetcher based on feedback Signed-off-by: Assem Hafez <assem.hafez@uber.com> * rename unmout to destroy Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Create hook for fetching history Signed-off-by: Assem Hafez <assem.hafez@uber.com> * move condition into executeImmediately Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update destroy in method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix type error with query params Signed-off-by: Assem Hafez <assem.hafez@uber.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> * fix: Autocomplete for bool values (#1072) Fix workflows query autocomplete to suggest the correct tokens for boolean values Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * Add feature flag for Failover History (#1070) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * Add failover history tab (#1071) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * chore: Added ts-node to dev-deps (#1074) Signed-off-by: Tim Chan <tim.chan@uber.com> * feat: Hook to fetch & filter Failover History of a domain (#1075) Add hook for fetching and filtering failover history Add helper function to check if a ClusterFailover matches a given cluster attribute Add some types/constants for domain page failovers Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: New Cron Tab (#1078) Signed-off-by: Tim Chan <tim.chan@uber.com> * feat: Failover History table (#1076) * Add table to display failover history of a domain, with support for both active-passive and active-active domains Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: Fix console.error pollution (#1077) * chore: Fix console.error pollution Signed-off-by: Tim Chan <tim.chan@uber.com> * Relocated to src/test-utils. Signed-off-by: Tim Chan <tim.chan@uber.com> --------- Signed-off-by: Tim Chan <tim.chan@uber.com> * Add flag for History Page v2 (#1081) Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Filters for Failover History Table (#1079) Add filters for Failover History table, but only for active-active domains Create filter for Cluster Attribute Scope, which depends on domain description to suggest possible scopes Create filter for Cluster Attribute Value, which depends on selected scope to suggest possible values/names Remove (now) unused styles file from DomainPageFailovers Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: Create a grouping utility that only parses new events (#1065) * grouping utility Signed-off-by: Assem Hafez <assem.hafez@uber.com> * update test cases Signed-off-by: Assem Hafez <assem.hafez@uber.com> * change the api of onChange and add destroy method Signed-off-by: Assem Hafez <assem.hafez@uber.com> * replace getGroups with getState Signed-off-by: Assem Hafez <assem.hafez@uber.com> * call onchange after updating pending events Signed-off-by: Assem Hafez <assem.hafez@uber.com> * use sync processBatch for first page Signed-off-by: Assem Hafez <assem.hafez@uber.com> * Update src/views/workflow-history/helpers/workflow-history-grouper.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply PR comments * Update src/views/workflow-history/helpers/workflow-history-grouper.types.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: Add modal to view full failover event (#1080) * Add modal for viewing an individual failover event, which is shown when "See more" in the table is clicked Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * feat: New components for Workflow History V2 (#1082) * Add new Workflow History V2 root component, which (for now) renders only a placeholder header component and placeholder tables. * Implement Workflow History Header with basic UI and sticky functionality * Add logic in WorkflowHistoryWrapper to render V2 UI based on feature flag Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> * update test cases * hook for history grouper * remove comments * fetcher updates * add placeholder for fetcher * update fetcher mock * fetcher start update * update todo * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix copilot comments * remove extra comment * lint fix * change lastFlattented initial value to -1 * remove unused import * address comments --------- Signed-off-by: Assem Hafez <assem.hafez@uber.com> Signed-off-by: Tim Chan <tim.chan@uber.com> Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com> Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com> Co-authored-by: Tim Chan <timothyc@alum.mit.edu> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
1 parent 620345a commit dba0b79

File tree

5 files changed

+190
-47
lines changed

5 files changed

+190
-47
lines changed

‎src/views/workflow-history/helpers/workflow-history-grouper.types.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { type HistoryEvent } from '@/__generated__/proto-ts/uber/cadence/api/v1/HistoryEvent';
2-
31
import type {
42
HistoryEventsGroups,
53
PendingActivityTaskStartEvent,

‎src/views/workflow-history/hooks/__tests__/use-initial-selected-event.test.ts‎

Lines changed: 149 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,61 +1,193 @@
11
import { renderHook } from '@/test-utils/rtl';
22

3-
import { completedDecisionTaskEvents } from '../../__fixtures__/workflow-history-decision-events';
3+
import {
4+
mockActivityEventGroup,
5+
mockDecisionEventGroup,
6+
mockTimerEventGroup,
7+
mockSingleEventGroup,
8+
} from '../../__fixtures__/workflow-history-event-groups';
9+
import { type HistoryEventsGroup } from '../../workflow-history.types';
410
import useInitialSelectedEvent from '../use-initial-selected-event';
511

6-
jest.mock('../../helpers/get-history-event-group-id');
7-
812
describe('useInitialSelectedEvent', () => {
9-
const events = [...completedDecisionTaskEvents];
10-
const filteredEventGroupsEntries: [string, any][] = [
11-
['group1', completedDecisionTaskEvents],
12-
];
13+
// Create a more realistic set of event groups with multiple types
14+
const mockEventGroups: Record<string, HistoryEventsGroup> = {
15+
'1': mockSingleEventGroup,
16+
'2': mockDecisionEventGroup,
17+
'5': mockActivityEventGroup,
18+
'10': mockTimerEventGroup,
19+
'11': mockDecisionEventGroup,
20+
'12': mockActivityEventGroup,
21+
};
22+
23+
it('should return shouldSearchForInitialEvent as true when selectedEventId is defined', () => {
24+
// Filtered entries contain only a subset of all event groups
25+
const filteredEventGroupsEntries: [string, HistoryEventsGroup][] = [
26+
['2', mockEventGroups['2']],
27+
['5', mockEventGroups['5']],
28+
];
1329

14-
it('should return shouldSearchForInitialEvent as true when initialEventId is defined', () => {
1530
const { result } = renderHook(() =>
1631
useInitialSelectedEvent({
1732
selectedEventId: '2',
18-
events,
33+
eventGroups: mockEventGroups,
1934
filteredEventGroupsEntries,
2035
})
2136
);
2237

2338
expect(result.current.shouldSearchForInitialEvent).toBe(true);
2439
});
2540

26-
it('should return shouldSearchForInitialEvent as false when initialEventId is undefined', () => {
41+
it('should return shouldSearchForInitialEvent as false when selectedEventId is undefined', () => {
42+
const filteredEventGroupsEntries: [string, HistoryEventsGroup][] = [
43+
['1', mockEventGroups['1']],
44+
['2', mockEventGroups['2']],
45+
['5', mockEventGroups['5']],
46+
];
47+
2748
const { result } = renderHook(() =>
2849
useInitialSelectedEvent({
2950
selectedEventId: undefined,
30-
events,
51+
eventGroups: mockEventGroups,
3152
filteredEventGroupsEntries,
3253
})
3354
);
3455

3556
expect(result.current.shouldSearchForInitialEvent).toBe(false);
3657
});
3758

38-
it('should return initialEventGroupIndex as undefined when initialEventId is defined & group is not found', () => {
59+
it('should return initialEventGroupIndex when event is found in a group and group key matches event ID', () => {
60+
// Filtered entries contain only a subset - event '2' is at index 1
61+
const filteredEventGroupsEntries: [string, HistoryEventsGroup][] = [
62+
['1', mockEventGroups['1']],
63+
['2', mockEventGroups['2']],
64+
['5', mockEventGroups['5']],
65+
];
66+
3967
const { result } = renderHook(() =>
4068
useInitialSelectedEvent({
41-
selectedEventId: '500',
42-
events,
43-
filteredEventGroupsEntries: [],
69+
selectedEventId: '2',
70+
eventGroups: mockEventGroups,
71+
filteredEventGroupsEntries,
72+
})
73+
);
74+
75+
expect(result.current.initialEventGroupIndex).toBe(1);
76+
expect(result.current.initialEventFound).toBe(true);
77+
});
78+
79+
it('should return initialEventGroupIndex as undefined when selectedEventId is defined & event is not found in filtered entries', () => {
80+
// Group '2' exists in mockEventGroups but is filtered out from the visible list
81+
const filteredEventGroupsEntries: [string, HistoryEventsGroup][] = [
82+
['1', mockEventGroups['1']],
83+
['10', mockEventGroups['10']],
84+
];
85+
86+
const { result } = renderHook(() =>
87+
useInitialSelectedEvent({
88+
selectedEventId: '2',
89+
eventGroups: mockEventGroups,
90+
filteredEventGroupsEntries,
4491
})
4592
);
4693

4794
expect(result.current.initialEventGroupIndex).toBe(undefined);
4895
});
4996

50-
it('should return initialEventFound as false when initialEventId is defined & event is not found', () => {
97+
it('should find event when group key does not match event ID but group contains the event', () => {
98+
// Group key is '5' but contains event with ID '7' (activity events)
99+
// The hook should find the event in the group regardless of the group key not matching
100+
// Event '7' is in group '5' which is at index 1 in filtered entries
101+
const filteredEventGroupsEntries: [string, HistoryEventsGroup][] = [
102+
['2', mockEventGroups['2']],
103+
['5', mockEventGroups['5']],
104+
];
105+
106+
const { result } = renderHook(() =>
107+
useInitialSelectedEvent({
108+
selectedEventId: '7',
109+
eventGroups: mockEventGroups,
110+
filteredEventGroupsEntries,
111+
})
112+
);
113+
114+
expect(result.current.initialEventFound).toBe(true);
115+
expect(result.current.initialEventGroupIndex).toBe(1);
116+
});
117+
118+
it('should return initialEventFound as false when selectedEventId is defined & event is not found in groups', () => {
119+
// Event ID '500' doesn't exist in any group
120+
const filteredEventGroupsEntries: [string, HistoryEventsGroup][] = [
121+
['1', mockEventGroups['1']],
122+
['2', mockEventGroups['2']],
123+
['5', mockEventGroups['5']],
124+
['10', mockEventGroups['10']],
125+
];
126+
51127
const { result } = renderHook(() =>
52128
useInitialSelectedEvent({
53129
selectedEventId: '500',
54-
events,
130+
eventGroups: mockEventGroups,
55131
filteredEventGroupsEntries,
56132
})
57133
);
58134

59135
expect(result.current.initialEventFound).toBe(false);
60136
});
137+
138+
it('should return initialEventFound as false when eventGroups is empty', () => {
139+
// Edge case: no event groups available at all
140+
const { result } = renderHook(() =>
141+
useInitialSelectedEvent({
142+
selectedEventId: '2',
143+
eventGroups: {},
144+
filteredEventGroupsEntries: [],
145+
})
146+
);
147+
148+
expect(result.current.initialEventFound).toBe(false);
149+
expect(result.current.initialEventGroupIndex).toBe(undefined);
150+
});
151+
152+
it('should find event at correct index when multiple groups are filtered', () => {
153+
// Realistic scenario: many groups but only some are visible after filtering
154+
// Event '7' is in group '5' which should be at index 2 in the filtered list
155+
const filteredEventGroupsEntries: [string, HistoryEventsGroup][] = [
156+
['1', mockEventGroups['1']],
157+
['2', mockEventGroups['2']],
158+
['5', mockEventGroups['5']],
159+
];
160+
161+
const { result } = renderHook(() =>
162+
useInitialSelectedEvent({
163+
selectedEventId: '7',
164+
eventGroups: mockEventGroups,
165+
filteredEventGroupsEntries,
166+
})
167+
);
168+
169+
expect(result.current.initialEventFound).toBe(true);
170+
expect(result.current.initialEventGroupIndex).toBe(2);
171+
});
172+
173+
it('should handle event at the end of filtered list', () => {
174+
// Event '16' is in group '10' which is at the last position in the filtered list
175+
const filteredEventGroupsEntries: [string, HistoryEventsGroup][] = [
176+
['1', mockEventGroups['1']],
177+
['2', mockEventGroups['2']],
178+
['5', mockEventGroups['5']],
179+
['10', mockEventGroups['10']],
180+
];
181+
182+
const { result } = renderHook(() =>
183+
useInitialSelectedEvent({
184+
selectedEventId: '16',
185+
eventGroups: mockEventGroups,
186+
filteredEventGroupsEntries,
187+
})
188+
);
189+
190+
expect(result.current.initialEventFound).toBe(true);
191+
expect(result.current.initialEventGroupIndex).toBe(3);
192+
});
61193
});

‎src/views/workflow-history/hooks/use-initial-selected-event.ts‎

Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
import { useMemo, useState } from 'react';
2-
3-
import getHistoryEventGroupId from '../helpers/get-history-event-group-id';
1+
import { useMemo, useRef, useState } from 'react';
42

53
import { type UseInitialSelectedEventParams } from './use-initial-selected-event.types';
64

@@ -12,27 +10,42 @@ import { type UseInitialSelectedEventParams } from './use-initial-selected-event
1210
*/
1311
export default function useInitialSelectedEvent({
1412
selectedEventId,
15-
events,
13+
eventGroups,
1614
filteredEventGroupsEntries,
1715
}: UseInitialSelectedEventParams) {
16+
// preserve initial event id even if prop changed.
1817
const [initialEventId] = useState(selectedEventId);
18+
const foundGroupIndexRef = useRef<number | undefined>(undefined);
1919

20-
const initialEvent = useMemo(() => {
20+
const initialEventGroupEntry = useMemo(() => {
2121
if (!initialEventId) return undefined;
22-
return events.find((e) => e.eventId === initialEventId);
23-
}, [events, initialEventId]);
22+
23+
return Object.entries(eventGroups).find(([_, group]) =>
24+
group.events.find((e) => e.eventId === initialEventId)
25+
);
26+
}, [eventGroups, initialEventId]);
2427

2528
const shouldSearchForInitialEvent = initialEventId !== undefined;
26-
const initialEventFound = initialEvent !== undefined;
29+
const initialEventFound = initialEventGroupEntry !== undefined;
2730

2831
const initialEventGroupIndex = useMemo(() => {
29-
if (!initialEvent) return undefined;
30-
const groupId = getHistoryEventGroupId(initialEvent);
32+
if (!initialEventGroupEntry) return undefined;
33+
34+
const groupId = initialEventGroupEntry[0];
35+
// If group index not change do not search again.
36+
if (
37+
foundGroupIndexRef.current &&
38+
filteredEventGroupsEntries[foundGroupIndexRef.current][0] === groupId
39+
)
40+
return foundGroupIndexRef.current;
41+
3142
const index = filteredEventGroupsEntries.findIndex(
3243
([id]) => id === groupId
3344
);
34-
return index > -1 ? index : undefined;
35-
}, [initialEvent, filteredEventGroupsEntries]);
45+
const foundGroupIndex = index > -1 ? index : undefined;
46+
foundGroupIndexRef.current = foundGroupIndex;
47+
return foundGroupIndex;
48+
}, [initialEventGroupEntry, filteredEventGroupsEntries]);
3649

3750
return {
3851
shouldSearchForInitialEvent,

‎src/views/workflow-history/hooks/use-initial-selected-event.types.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import { type HistoryEvent } from '@/__generated__/proto-ts/uber/cadence/api/v1/HistoryEvent';
1+
import { type HistoryEventsGroup } from '../workflow-history.types';
22

33
export type UseInitialSelectedEventParams = {
4-
events: HistoryEvent[];
4+
eventGroups: Record<string, HistoryEventsGroup>;
55
selectedEventId?: string;
6-
filteredEventGroupsEntries: [string, any][];
6+
filteredEventGroupsEntries: [string, HistoryEventsGroup][];
77
};

‎src/views/workflow-history/workflow-history.tsx‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ import { WORKFLOW_HISTORY_PAGE_SIZE_CONFIG } from './config/workflow-history-pag
2929
import compareUngroupedEvents from './helpers/compare-ungrouped-events';
3030
import getSortableEventId from './helpers/get-sortable-event-id';
3131
import getVisibleGroupsHasMissingEvents from './helpers/get-visible-groups-has-missing-events';
32-
import { groupHistoryEvents } from './helpers/group-history-events';
3332
import pendingActivitiesInfoToEvents from './helpers/pending-activities-info-to-events';
3433
import pendingDecisionInfoToEvent from './helpers/pending-decision-info-to-event';
3534
import useEventExpansionToggle from './hooks/use-event-expansion-toggle';
3635
import useInitialSelectedEvent from './hooks/use-initial-selected-event';
3736
import useWorkflowHistoryFetcher from './hooks/use-workflow-history-fetcher';
37+
import useWorkflowHistoryGrouper from './hooks/use-workflow-history-grouper';
3838
import WorkflowHistoryCompactEventCard from './workflow-history-compact-event-card/workflow-history-compact-event-card';
3939
import { WorkflowHistoryContext } from './workflow-history-context-provider/workflow-history-context-provider';
4040
import WorkflowHistoryHeader from './workflow-history-header/workflow-history-header';
@@ -59,6 +59,12 @@ export default function WorkflowHistory({ params }: Props) {
5959
waitForNewEvent: true,
6060
};
6161

62+
const {
63+
eventGroups,
64+
updateEvents: updateGrouperEvents,
65+
updatePendingEvents: updateGrouperPendingEvents,
66+
} = useWorkflowHistoryGrouper();
67+
6268
const {
6369
historyQuery,
6470
startLoadingHistory,
@@ -73,8 +79,7 @@ export default function WorkflowHistory({ params }: Props) {
7379
pageSize: wfHistoryRequestArgs.pageSize,
7480
waitForNewEvent: wfHistoryRequestArgs.waitForNewEvent,
7581
},
76-
//TODO: @assem.hafez replace this with grouper callback
77-
() => {},
82+
updateGrouperEvents,
7883
2000
7984
);
8085

@@ -125,24 +130,19 @@ export default function WorkflowHistory({ params }: Props) {
125130
[result]
126131
);
127132

128-
const pendingHistoryEvents = useMemo(() => {
133+
useEffect(() => {
129134
const pendingStartActivities = pendingActivitiesInfoToEvents(
130135
wfExecutionDescription.pendingActivities
131136
);
132137
const pendingStartDecision = wfExecutionDescription.pendingDecision
133138
? pendingDecisionInfoToEvent(wfExecutionDescription.pendingDecision)
134139
: null;
135140

136-
return {
141+
updateGrouperPendingEvents({
137142
pendingStartActivities,
138143
pendingStartDecision,
139-
};
140-
}, [wfExecutionDescription]);
141-
142-
const eventGroups = useMemo(
143-
() => groupHistoryEvents(events, pendingHistoryEvents),
144-
[events, pendingHistoryEvents]
145-
);
144+
});
145+
}, [wfExecutionDescription, updateGrouperPendingEvents]);
146146

147147
const filteredEventGroupsEntries = useMemo(
148148
() =>
@@ -235,7 +235,7 @@ export default function WorkflowHistory({ params }: Props) {
235235
shouldSearchForInitialEvent,
236236
} = useInitialSelectedEvent({
237237
selectedEventId: queryParams.historySelectedEventId,
238-
events,
238+
eventGroups,
239239
filteredEventGroupsEntries,
240240
});
241241

0 commit comments

Comments
 (0)