Skip to content

Correct inconsistent function name usage in code refactoring exercise #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct inconsistent function name usage in code refactoring exercise #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions episodes/34-code-refactoring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ i.e. their tests are:
::: challenge
## Exercise: Testing a Pure Function

Add tests for `compute_standard_deviation_by_data()` that check for situations
Add tests for `compute_standard_deviation_by_day()` that check for situations
when there is only one file with multiple rows,
multiple files with one row, and any other cases you can think of that should be tested.

Expand All @@ -299,9 +299,9 @@ with more inputs and expected outputs:
],
ids=['Two patients in same file', 'Two patients in different files', 'Two identical patients in two different files'])
def test_compute_standard_deviation_by_day(data, expected_output):
from inflammation.compute_data import compute_standard_deviation_by_data
from inflammation.compute_data import compute_standard_deviation_by_day

result = compute_standard_deviation_by_data(data)
result = compute_standard_deviation_by_day(data)
npt.assert_array_almost_equal(result, expected_output)
```

Expand Down