Issue #124: Implement recipe for NewlineAtEndOfFile #125
Conversation
Anmol202005
force-pushed
the
eol
branch
15 times, most recently
from
8b311bc to
e5cc5a3
Compare
|
Finally got CI GREEN. @rdiachenko pls review :) |
|
@romani @rdiachenko ping. |
.gitattributes
Outdated
| src/test/resources/org/checkstyle/autofix/recipe/newlineatendoffile/** -text | ||
|
|
||
| # Force LF line endings for diff test files | ||
| *.diff text eol=lf No newline at end of file |
There was a problem hiding this comment.
please add \n to end of this file,
| J result = (J) tree; | ||
|
|
||
| if (tree instanceof JavaSourceFile) { | ||
| final JavaSourceFile sourceFile = (JavaSourceFile) tree; |
There was a problem hiding this comment.
if (tree instanceof JavaSourceFile sourceFile) {
| } | ||
|
|
||
| private String determineLineEnding(JavaSourceFile sourceFile) { | ||
| return switch (lineSeparatorConfig.toLowerCase()) { |
There was a problem hiding this comment.
please do toLowerCase() in constructor to do this only in whole execution.
| final Path filePath = sourceFile.getSourcePath().toAbsolutePath(); | ||
|
|
||
| if (hasViolation(filePath)) { | ||
| final String lineEnding = determineLineEnding(sourceFile); |
There was a problem hiding this comment.
reanem lineEnding to expectedLineEnding
| final Space eof = sourceFile.getEof(); | ||
| final String lastWhitespace = eof.getLastWhitespace(); | ||
|
|
||
| if (!lineEnding.equals(lastWhitespace)) { |
There was a problem hiding this comment.
we do not trust checkstyle violation ? or it is save check in case of second execution.
There was a problem hiding this comment.
this is a check for second execution.
|
|
||
| private boolean hasViolation(Path filePath) { | ||
| return violations.removeIf(violation -> { | ||
| return violation.getFilePath().endsWith(filePath); |
There was a problem hiding this comment.
why we do removal from collection of violation ?
is this prevention of double execution ?
There was a problem hiding this comment.
No need to do this since we already do a check. reverted this.
2 participants
Fixes: #124
Implemented recipe for NewlineAtEndOfFile: https://checkstyle.sourceforge.io/checks/misc/newlineatendoffile.html