-
Notifications
You must be signed in to change notification settings - Fork 10
Security Assessment: Reviewed multiple CVEs #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
allenpais
wants to merge
1
commit into
main
Choose a base branch
from
microsoft/apais-Feb6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| reachability: Local | ||
| memory_corruption: False | ||
| bug_class: Logical Error | ||
| impact: DoS | ||
| privileges_required: Low | ||
| notes: inconsistency in handling expired elements during nftables set walks, leading to incorrect reference counting. | ||
| author: Microsoft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| reachability: Local | ||
| memory_corruption: False | ||
| bug_class: Logical Error | ||
| impact: DoS | ||
| privileges_required: Low | ||
| notes: incorrect handling of expired elements in nftables, leading to unexpected failures in insertion operations. | ||
| author: Microsoft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| reachability: Local | ||
| memory_corruption: True | ||
| bug_class: Use-After-Free | ||
| impact: Kernel Panic | ||
| privileges_required: Low | ||
| notes: `zram_meta_free` may access the freed table, leading to a use-after-free vulnerability causing kernel panic. | ||
| author: Microsoft | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| reachability: Local | ||
| memory_corruption: False | ||
| bug_class: Logical Error | ||
| impact: Deadlock | ||
| privileges_required: Low | ||
| notes: merge preference rule failure, leading to a missing lock(inode lock) release. | ||
| author: Micrsoft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| reachability: Local | ||
| memory_corruption: True | ||
| bug_class: Use-After-Free | ||
| impact: Kernel Panic | ||
| privileges_required: Low | ||
| notes: `server->hostname` is freed while a background CIFS daemon thread is still using it, leading to a double-free scenario. | ||
| author: Microsoft |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Red Hat this seems to be a LPE, while SUSE classifies this as just as DoS. Can you share a bit more context behind your assessment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The freed zram->table can still be accessed later, leading to invalid memory dereferences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please integrate that into the notes?