Skip to content

Clean up logic for determining the active model provider #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 27, 2025
Merged

Clean up logic for determining the active model provider #309

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c8254b7
Parametrize ModelProvider fixture directly
mliu-cloudera Aug 22, 2025
9b0f0a1
Simplify clearing env vars
mliu-cloudera Aug 22, 2025
e2f5240
Move get_model_source() to the tops of classes
mliu-cloudera Aug 22, 2025
a95f051
Factor out get_provider_class()
mliu-cloudera Aug 22, 2025
077f855
Rename is_enabled() to env_vars_are_set()
mliu-cloudera Aug 22, 2025
53b3d8b
Privatize ModelProvider base class
mliu-cloudera Aug 22, 2025
d46955c
Rework get_provider_class()
mliu-cloudera Aug 22, 2025
4af55d7
Remove redundant ModelProviderType
mliu-cloudera Aug 22, 2025
cc81c1a
Clean up logs
mliu-cloudera Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions llm-service/app/tests/services/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def get_all_env_var_names() -> set[str]:
)


@pytest.fixture()
@pytest.fixture(params=ModelProvider.__subclasses__())
def EnabledModelProvider(
request: pytest.FixtureRequest,
monkeypatch: pytest.MonkeyPatch,
Expand All @@ -71,11 +71,6 @@ def EnabledModelProvider(
return ModelProviderSubcls


@pytest.mark.parametrize(
"EnabledModelProvider",
ModelProvider.__subclasses__(),
indirect=True,
)
class TestListAvailableModels:
@pytest.fixture(autouse=True)
def caii_get_models(self, monkeypatch: pytest.MonkeyPatch) -> None:
Expand Down
Loading