Merge #156799

156799: logical: fix creation time check for REFCURSOR r=jeffswenson a=jeffswenson

This fixes a bug that was uncovered by TestRandomTables. Compound types that include REFCURSORs could sneak by the validation.

Epic: CRDB-48647
Release note: none

Co-authored-by: Jeff Swenson <jeffswenson@betterthannull.com>

Author: craig[bot]

pkg/crosscluster/logical/logical_replication_job_test.go

@@ -2845,7 +2845,7 @@ func TestLogicalReplicationCreationChecks(t *testing.T) {
 	// Check that REFCURSOR columns are not allowed.
 	dbA.Exec(t, "CREATE TABLE tab_with_refcursor (pk INT PRIMARY KEY, curs REFCURSOR)")
 	dbB.Exec(t, "CREATE TABLE b.tab_with_refcursor (pk INT PRIMARY KEY, curs REFCURSOR)")
-	expectErr(t, "tab_with_refcursor", "cannot create logical replication stream: column curs is a RefCursor")
+	expectErr(t, "tab_with_refcursor", "cannot create logical replication stream: RefCursor is not supported by LDR")
 
 	// Add different default values to to the source and dest, verify the stream
 	// can be created, and that the default value is sent over the wire.

pkg/sql/catalog/tabledesc/logical_replication_helpers.go

@@ -66,12 +66,30 @@ func CheckLogicalReplicationCompatibility(
 }
 
 func checkForbiddenTypes(dst *descpb.TableDescriptor) error {
+	var isForbiddenType func(typ *types.T) error
+	isForbiddenType = func(typ *types.T) error {
+		switch typ.Family() {
+		case types.RefCursorFamily:
+			// RefCursor is not supported by LDR because it has no definition of
+			// equality. It's a weird type that should never exist in a durable table
+			// since a cursor is a session scoped entity.
+			return errors.Newf("RefCursor is not supported by LDR")
+		case types.ArrayFamily:
+			return isForbiddenType(typ.ArrayContents())
+		case types.TupleFamily:
+			for _, tupleTyp := range typ.TupleContents() {
+				if err := isForbiddenType(tupleTyp); err != nil {
+					return err
+				}
+			}
+			return nil
+		default:
+			return nil
+		}
+	}
 	for _, col := range dst.Columns {
-		// RefCursor is not supported by LDR because it has no definition of
-		// equality. It's a weird type that should never exist in a durable table
-		// since a cursor is a session scoped entity.
-		if col.Type.Family() == types.RefCursorFamily {
-			return errors.Newf("column %s is a RefCursor", col.Name)
+		if err := isForbiddenType(col.Type); err != nil {
+			return err
 		}
 	}
 	return nil