sql: remove createTestServerParamsAllowTenants #156986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
yuzefovich
force-pushed
the
tenant-cleanup
branch
from
2181ac3 to
165a542
Compare
Release note: None
yuzefovich
force-pushed
the
tenant-cleanup
branch
from
165a542 to
216fabf
Compare
This commit removes `createTestServerParamsAllowTenants`. Previously, this method returned two arguments, but the second one was only used only in a handful of spots - we now inline the necessary code to create CommandFilters in each spots. In all other spots the helper method no longer (given the change in the previous commit) provided any value, so we replaced all its usages with directly constructing the TestServerArgs. Additionally some stale comments are removed. Release note: None
yuzefovich
force-pushed
the
tenant-cleanup
branch
from
216fabf to
69524ea
Compare
yuzefovich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade: remove unused SQLStats testing knobs
sql: do not set sqlstats knobs
This was added in 2fad679 because we called CreateTestServerParams in other tests. That is no longer the case as of 5adea01, so I don't think we need that.
sql: remove createTestServerParamsAllowTenants
This commit removes
createTestServerParamsAllowTenants. Previously, this method returned two arguments, but the second one was only used only in a handful of spots - we now inline the necessary code to create CommandFilters in each spots. In all other spots the helper method no longer (given the change in the previous commit) provided any value, so we replaced all its usages with directly constructing the TestServerArgs.Additionally some stale comments are removed.
Epic: None