Skip to content

release-25.4: roachtest: lower concurrency during sysbench prepare #157011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-25.4
Choose a base branch
from
+9 −3
Open

release-25.4: roachtest: lower concurrency during sysbench prepare #157011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pkg/cmd/roachtest/tests/sysbench.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,15 @@ func runSysbench(ctx context.Context, t test.Test, c cluster.Cluster, opts sysbe
var start time.Time
runWorkload := func(ctx context.Context) error {
t.Status("preparing workload")
cmd := opts.cmd(useHAProxy /* haproxy */)
{
result, err := c.RunWithDetailsSingleNode(ctx, t.L(), option.WithNodes(c.WorkloadNode()), roachtestutil.PrefixCmdOutputWithTimestamp(cmd+" prepare"))
opts := opts
// We often see the prepare phase hit `result is ambiguous: error=replica unavailable`
// due to io overload. Sysbench prepare parallelizes work based on number of tables,
// so limit concurrency to half the number of tables so we aren't inserting into every
// table at once.
opts.concurrency = opts.tables / 2

result, err := c.RunWithDetailsSingleNode(ctx, t.L(), option.WithNodes(c.WorkloadNode()), roachtestutil.PrefixCmdOutputWithTimestamp(opts.cmd(useHAProxy)+" prepare"))
if err != nil {
return err
} else if msg, crashed := detectSysbenchCrash(result); crashed {
Expand Down Expand Up @@ -231,7 +237,7 @@ func runSysbench(ctx context.Context, t test.Test, c cluster.Cluster, opts sysbe

t.Status("running workload")
start = timeutil.Now()
result, err := c.RunWithDetailsSingleNode(ctx, t.L(), option.WithNodes(c.WorkloadNode()), roachtestutil.PrefixCmdOutputWithTimestamp(cmd+" run"))
result, err := c.RunWithDetailsSingleNode(ctx, t.L(), option.WithNodes(c.WorkloadNode()), roachtestutil.PrefixCmdOutputWithTimestamp(opts.cmd(useHAProxy)+" run"))

if msg, crashed := detectSysbenchCrash(result); crashed {
t.Skipf("%s; skipping test", msg)
Expand Down