Skip to content

workload: validate bank rows flag #157050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
+118 −112
Draft

workload: validate bank rows flag #157050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc971a4
workload: validate bank rows flag
herkolategan Oct 20, 2025
4779e11
backup: use more than 1 row in bank workload
herkolategan Nov 7, 2025
b1455f9
bank: update the ops function to consider validation
herkolategan Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/backup/alter_backup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func TestAlterBackupStatement(t *testing.T) {
key2 := getAWSEncryptionOption(t, "NEW_AWS_KMS_REGION", "NEW_AWS_KEY_ID")

const userfile = "'userfile:///a'"
const numAccounts = 1
const numAccounts = 2

tc, sqlDB, _, cleanupFn := backupRestoreTestSetup(t, singleNode, numAccounts, InitManualReplication)
execCfg := tc.Server(0).ExecutorConfig().(sql.ExecutorConfig)
Expand Down Expand Up @@ -77,7 +77,7 @@ func TestAlterBackupRestore(t *testing.T) {
newURI := getAWSEncryptionOption(t, "NEW_AWS_KMS_REGION", "NEW_AWS_KEY_ID")

const userfile = "'userfile:///a'"
const numAccounts = 1
const numAccounts = 2

_, sqlDB, _, cleanupFn := backupRestoreTestSetup(t, singleNode, numAccounts, InitManualReplication)
defer cleanupFn()
Expand Down Expand Up @@ -178,7 +178,7 @@ func TestAlterBackupIncremental(t *testing.T) {
newURI := getAWSEncryptionOption(t, "NEW_AWS_KMS_REGION", "NEW_AWS_KEY_ID")

const userfile = "'userfile:///a'"
const numAccounts = 1
const numAccounts = 2

_, sqlDB, _, cleanupFn := backupRestoreTestSetup(t, singleNode, numAccounts, InitManualReplication)
defer cleanupFn()
Expand Down
2 changes: 1 addition & 1 deletion pkg/backup/backup_cloud_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ func TestCloudBackupRestoreKMSInaccessibleMetric(t *testing.T) {
uri: fmt.Sprintf("azure-kms:///non-existent-key/000?AUTH=implicit&AZURE_VAULT_NAME=%s", azureVaultName),
},
} {
tc, sqlDB, _, cleanupFn := backupRestoreTestSetup(t, 1, 1, InitManualReplication)
tc, sqlDB, _, cleanupFn := backupRestoreTestSetup(t, 1, 2, InitManualReplication)
defer cleanupFn()

t.Run(tt.name, func(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/backup/backup_tenant_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func TestBackupSharedProcessTenantNodeDown(t *testing.T) {
},
}
params.ServerArgs.Knobs.JobsTestingKnobs = jobs.NewTestingKnobsWithShortIntervals()
tc, hostDB, _, cleanup := backupRestoreTestSetupWithParams(t, multiNode, 0, /* numAccounts */
tc, hostDB, _, cleanup := backupRestoreTestSetupWithParams(t, multiNode, 2, /* numAccounts */
InitManualReplication, params)
defer cleanup()

Expand Down
Loading