-
Notifications
You must be signed in to change notification settings - Fork 4k
release-24.3: roachtest: deflake activerecord #157092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently, the activerecord test suite is failing on the quoting subtests. To address this we will add those tests into the ignore list. Fixes: cockroachdb#156441 Release note: None
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
|
✅ PR #157092 is compliant with backport policy Confidence: high 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
| `ActiveRecord::CockroachDBStructureDumpTest#test_structure_dump`: "flaky", | ||
| `ActiveRecord::ConnectionAdapters::ConnectionPoolThreadTest#test_checkout_fairness_by_group`: "flaky", | ||
| `ActiveRecord::ConnectionAdapters::PostgreSQLAdapterTest#test_translate_no_connection_exception_to_not_established`: "pg_terminate_backend not implemented", | ||
| `ActiveRecord::ConnectionAdapters::PostgreSQLAdapter::QuotingTest#test_quote_big_decimal`: "unknown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, i noticed that another test is failing too:
--- FAIL: ActiveRecord::InvertibleMigrationTest#test_migrate_revert_add_unique_constraint_with_invalid_option (unexpected)
Currently, the activerecord test suite is failing on the quoting subtests. To address this we will add those tests into the ignore list.
Fixes: #156441
Release note: None
Release justification: test only change