Skip to content

Conversation

@fqazi
Copy link
Collaborator

@fqazi fqazi commented Nov 7, 2025

Currently, the activerecord test suite is failing on the quoting subtests. To address this we will add those tests into the ignore list.

Fixes: #156441

Release note: None

Release justification: test only change

Currently, the activerecord test suite is failing on the quoting
subtests. To address this we will add those tests into the ignore list.

Fixes: cockroachdb#156441

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi fqazi requested a review from a team November 7, 2025 22:40
@blathers-crl
Copy link

blathers-crl bot commented Nov 7, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Nov 7, 2025
@blathers-crl
Copy link

blathers-crl bot commented Nov 7, 2025

✅ PR #157092 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The PR falls under the non-production exemption, as it modifies code within the 'pkg/cmd/roachtest/' directory, which is explicitly mentioned in the policy for CockroachDB backport compliance as a development tools area. Since this PR changes a testing file and the PR's body includes a 'Release justification: test only change' line, it is exempt from the standard backport policy requirements.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Nov 7, 2025
@rafiss rafiss merged commit cc417b5 into cockroachdb:release-24.3 Nov 8, 2025
16 checks passed
`ActiveRecord::CockroachDBStructureDumpTest#test_structure_dump`: "flaky",
`ActiveRecord::ConnectionAdapters::ConnectionPoolThreadTest#test_checkout_fairness_by_group`: "flaky",
`ActiveRecord::ConnectionAdapters::PostgreSQLAdapterTest#test_translate_no_connection_exception_to_not_established`: "pg_terminate_backend not implemented",
`ActiveRecord::ConnectionAdapters::PostgreSQLAdapter::QuotingTest#test_quote_big_decimal`: "unknown",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, i noticed that another test is failing too:

--- FAIL: ActiveRecord::InvertibleMigrationTest#test_migrate_revert_add_unique_constraint_with_invalid_option (unexpected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) target-release-24.3.24

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants