[WIP] clusterversion: bump MinSupported - with fixes #157097
Draft
+93
−18,490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the minimum supported cluster version from 25.2 to 25.3, removing all 25.2-specific code and infrastructure. Changes include: - Updated MinSupported constant from V25_2 to V25_3 - Renamed V25_3_* version keys with TODO_Delete_ prefix - Updated Pebble MinimumSupportedFormatVersion - Removed 25.2 bootstrap data files (4 files) - Deleted release_25_2 schema changer rules (~30 files) - Removed local-mixed-25.2 and cockroach-go-testserver-25.2 logictest configs - Updated skipif directives in ~200+ test files - Regenerated Bazel build files Part of M.4 task (quarterly version bump process). Release note (ops change): The minimum supported version for upgrades is now 25.3. Clusters running 25.2 or earlier must upgrade to 25.3 before upgrading to this version. Epic: None 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
After bumping MinSupported from V25.2 to V25.3, several logic test cases that were conditionally executed only for local-mixed-25.2 configurations are no longer valid. These tests checked for version- gated behavior that is now always available in 25.3+. Changes: - role: Remove tests expecting PROVISIONSRC errors (feature now available) - user: Remove user_provisioning_gating_mixed_version subtest - udf_in_table: Remove duplicate CREATE TABLE statement for 25.2 compat - udf_unsupported: Remove tests for UDF restrictions lifted in 25.3 These changes fix test failures in 3node-tenant configuration where the removed guards caused tests to run with incorrect expectations. Release note: None 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
celiala
changed the title
After the initial cleanup, additional test failures revealed more cases that were conditionally guarded for local-mixed-25.2: - udf_unsupported: Remove duplicate error checks for "usage of user- defined function from relations not supported" (lines 25-32). The error message changed to "cannot evaluate function in this context" in 25.3+. - user: Remove check expecting estimated_last_login_time column to not exist in SHOW USERS (lines 278-279). This column now exists in 25.3+. - udf_in_table: Remove second duplicate CREATE TABLE t1 statement (lines 539-545) that was for 25.2 compatibility. These fixes resolve: - TestTenantLogic_udf_unsupported/disallow_udf_in_table - TestTenantLogic_user/validate_estimated_last_login_time - TestTenantLogic_udf_in_table relation already exists error Release note: None 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the minimum supported cluster version from 25.2 to 25.3,
removing all 25.2-specific code and infrastructure.
Changes include:
Part of M.4 task (quarterly version bump process).
Release note (ops change): The minimum supported version for upgrades is now
25.3. Clusters running 25.2 or earlier must upgrade to 25.3 before upgrading
to this version.
Epic: None
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com