Skip to content

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Nov 14, 2025

Part of #888

Completes the mission to replace all remaining usages of CLI UI packages @poppinss/cliui and @isaacs/cliui. Previous PRs (#1138, #1140) replaced all the basic logs, while this PR replaces the more complex table formatting.

I've implemented a custom ASCII table formatter, which replaces 2 different 3rd party tables as well as a 3rd party sticker implementation. The results are more or less the same (see snapshots). For defining the structure, I reused our Table data type from audit details.

The custom table implementation still uses a couple of 3rd party packages - string-width and wrap-ansi - but these are useful low-level utilities that are already used by all these CLI UI packages anyway.

@nx-cloud
Copy link

nx-cloud bot commented Nov 14, 2025

View your CI Pipeline Execution ↗ for commit d2091ed

Command Status Duration Result
nx affected -t e2e-test --parallel=1 ✅ Succeeded 12m 17s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-14 21:01:18 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1146

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1146

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1146

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1146

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1146

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1146

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1146

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1146

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1146

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1146

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1146

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1146

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1146

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1146

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1146

commit: d2091ed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit e305ee0 with previous commit 9293a18.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 32 🔴 34 ↑ +1.8
Code coverage 🟡 88 🟡 89 ↑ +0.4
Documentation 🔴 35 🔴 35 ↓ −0.1
Security 🔴 35 🔴 35
Updates 🟡 75 🟡 75
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 2 groups improved, 👎 1 group regressed, 👍 5 audits improved, 👎 5 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 32 🔴 34 ↑ +1.8
Code coverage Code coverage metrics 🟡 88 🟡 89 ↑ +0.4
JSDoc coverage Documentation coverage 🔴 35 🔴 35 ↓ −0.1

20 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Reduce unused CSS 🟨 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↑ +∞ %
Lighthouse First Contentful Paint 🟥 4.1 s 🟥 3.2 s ↓ −22.4 %
Lighthouse Speed Index 🟥 7.2 s 🟥 7.3 s ↑ +1.6 %
Lighthouse Total Blocking Time 🟥 2,180 ms 🟥 2,430 ms ↑ +11.9 %
Lighthouse Time to Interactive 🟥 13.6 s 🟥 13.8 s ↑ +1.8 %
Code coverage Function coverage 🟨 89.7 % 🟩 90.2 % ↑ +0.5 %
JSDoc coverage Functions coverage 🟥 539 undocumented functions 🟥 558 undocumented functions ↑ +3.5 %
Code coverage Branch coverage 🟨 86.6 % 🟨 86.9 % ↑ +0.3 %
Code coverage Line coverage 🟨 84.5 % 🟨 84.7 % ↑ +0.3 %
JSDoc coverage Types coverage 🟥 243 undocumented types 🟥 242 undocumented types ↓ −0.4 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,013 KiB 🟩 Total size was 2,017 KiB ↑ +0.2 %
Lighthouse JavaScript execution time 🟥 4.6 s 🟥 5.5 s ↑ +18.9 %
Lighthouse Max Potential First Input Delay 🟥 1,130 ms 🟥 1,640 ms ↑ +45.4 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +1.8 %
Lighthouse Minimizes main-thread work 🟥 13.8 s 🟥 14.0 s ↑ +1.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Largest Contentful Paint 🟥 11.5 s 🟥 11.6 s ↑ +1.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 98 KiB 🟥 Potential savings of 105 KiB ↓ −28.3 %
Lighthouse Server Backend Latencies 🟩 1,110 ms 🟩 990 ms ↓ −11.2 %
Lighthouse Initial server response time was short 🟩 Root document took 480 ms 🟩 Root document took 570 ms ↑ +19.4 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 160 KiB 🟥 Potential savings of 183 KiB ↑ +7.9 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 50 ms ↑ +138.3 %
JS Packages Outdated NPM prod dependencies. 🟨 18 outdated package versions (6 major, 8 minor, 4 patch) 🟨 17 outdated package versions (6 major, 7 minor, 4 patch) ↓ −5.6 %

655 other audits are unchanged.

@matejchalk matejchalk force-pushed the replace-cli-table branch 2 times, most recently from b05fd45 to 310b314 Compare November 14, 2025 16:39
@matejchalk matejchalk marked this pull request as ready for review November 14, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants