-
Notifications
You must be signed in to change notification settings - Fork 16
feat(utils): replace @poppinss/cliui and @isaacs/cliui with custom ascii table formatting #1146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matejchalk
wants to merge
9
commits into
main
Choose a base branch
from
replace-cli-table
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit d2091ed
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/core
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
@code-pushup/models-transformers
commit: |
2c3ef70 to
dc6a11c
Compare
Contributor
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit e305ee0 with previous commit 9293a18. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 2 groups improved, 👎 1 group regressed, 👍 5 audits improved, 👎 5 audits regressed, 13 audits changed without impacting score🗃️ Groups
20 other groups are unchanged. 🛡️ Audits
655 other audits are unchanged. |
b05fd45 to
310b314
Compare
310b314 to
d2091ed
Compare
vmasek
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #888
Completes the mission to replace all remaining usages of CLI UI packages
@poppinss/cliuiand@isaacs/cliui. Previous PRs (#1138, #1140) replaced all the basic logs, while this PR replaces the more complex table formatting.I've implemented a custom ASCII table formatter, which replaces 2 different 3rd party tables as well as a 3rd party sticker implementation. The results are more or less the same (see snapshots). For defining the structure, I reused our
Tabledata type from audit details.The custom table implementation still uses a couple of 3rd party packages -
string-widthandwrap-ansi- but these are useful low-level utilities that are already used by all these CLI UI packages anyway.