Add semantic accessors to macros #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inaki-amatria
requested review from
alvrogd and
daniel-otero
and removed request for
a team
inaki-amatria
force-pushed
the
feature/AddSemanticAccesors
branch
from
d1e2251 to
ed304a1
Compare
jgonzac
approved these changes
Mar 31, 2025
daniel-otero
approved these changes
Mar 31, 2025
daniel-otero
left a comment
daniel-otero
left a comment
There was a problem hiding this comment.
Care to document a little bit why the changes are required?
I don't have anything against them, but they seems rather arbitrary.
This way we can query the node and implement children-specific logic to `content` and `alternative`. The nodes below `content` and `alternative` may be Fortran nodes and not preprocessor directives!! So, for instance, we want to use `&` as line separator instead of `\`.
We don't want the newline token to show in the AST as it would make our passes sensible to that specific token. For instance if the source was ```fortran \#ifdef HAVE_THING ! foo \#endif ``` we wouldn't want to visit the newline character and make our column limit algorithm split the `#ifdef` as ```fortran \#ifdef HAVE_THING \ ! foo \#endif ``` In other words, this commit is hidding the newline character in the AST.
inaki-amatria
force-pushed
the
feature/AddSemanticAccesors
branch
from
d244a7f to
aec9397
Compare
Member
Author
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title is self-explanatory.