Added trim function on submit for the ipAddress to eliminate any lead… #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing or trailing white spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Trailing white spaces when entering IP address for a remote server doesn't allow it to actually connect, and causes issues for the user.
Here is a Mal formated remote server with leading white spaces
it ends up failing when we try to ssh into it
Our solution:
Add .trim() to the ip_address when it gets submited by the frontend. The video shows a walk through of a fixed version, and where we ended up changing the code. https://cap.so/s/efqrfeyj84twtgb