🤖 fix: use dvh units for body height #555
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
100vhwith100dvhfor the main app container to fix content clipping on mobile browsers with dynamic UI chrome.Mobile Safari and other mobile browsers show/hide the address bar and toolbar on scroll. Using
100vhcauses content to be cut off when this chrome is visible because100vhrepresents the maximum viewport height (when chrome is hidden).The
100dvhunit dynamically adapts to the actual visible viewport height as the browser chrome appears and disappears, preventing content from being clipped.Generated with
cmux