Skip to content

Conversation

@dhmmasson
Copy link
Contributor

Description

Add a new third party commitizen: a Deno provider.

Checklist

  • [-] Add test cases to all the changes you introduce
  • [-] Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • [-] Test the changes on the local machine manually
  • Update the documentation for the changes

Additional context

Related to #1257

@codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (120d514) to head (e7045a8).
Report is 460 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
+ Coverage   97.33%   97.66%   +0.33%     
==========================================
  Files          42       55      +13     
  Lines        2104     2575     +471     
==========================================
+ Hits         2048     2515     +467     
- Misses         56       60       +4     
Flag Coverage Δ
unittests 97.66% <ø> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Create a top level heading for provider to mirror the template heading
- Uniformize the installation/usage sub-heading for each template/provider
- Uniformize the code-block syntax highlighting
@dhmmasson
Copy link
Contributor Author

dhmmasson commented Oct 15, 2024

I have updated as requested my section 00d5ab8
I have also proposed a more general overall in the general direction of the comments : e7045a8

  • uniform use of sh/bash in the code blocks
  • More uniform level heading (top level for provider, installation/usage for all templates)

I can revert the last commit if the change is an issue, one thing I didn't know how to do with mkdocs is to limit the TOC to level 3, as it is a bit to busy right now

@Lee-W
Copy link
Member

Lee-W commented Oct 16, 2024

I have updated as requested my section 00d5ab8 I have also proposed a more general overall in the general direction of the comments : e7045a8

* uniform use of sh/bash in the code blocks

* More uniform level heading (top level for provider, installation/usage for all templates)

I can revert the last commit if the change is an issue, one thing I didn't know how to do with mkdocs is to limit the TOC to level 3, as it is a bit to busy right now

Thanks sooo much! You have already done so many great things!

@Lee-W Lee-W merged commit 1d5f295 into commitizen-tools:master Oct 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants