Skip to content

Conversation

@vemilano
Copy link
Contributor

@vemilano vemilano commented Sep 4, 2025

Description

Closes #1581

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external) in the documentation

@woile
Copy link
Member

woile commented Sep 4, 2025

Thanks for the PR! It's great, although I think it's a bit more complex.
I would like to see a test covering this example: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-members-and-exclude-fields

[workspace]
members = ["member1", "path/to/member2", "crates/*"]
exclude = ["crates/foo", "path/to/other"]

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.91%. Comparing base (120d514) to head (f0bdea5).
⚠️ Report is 764 commits behind head on master.

Files with missing lines Patch % Lines
commitizen/providers/cargo_provider.py 93.75% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
+ Coverage   97.33%   97.91%   +0.57%     
==========================================
  Files          42       58      +16     
  Lines        2104     2728     +624     
==========================================
+ Hits         2048     2671     +623     
- Misses         56       57       +1     
Flag Coverage Δ
unittests 97.91% <93.75%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@woile woile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lee-W
Copy link
Member

Lee-W commented Sep 5, 2025

I'll try to take a look next week but don't need to wait for me. Feel free to just merge it :)

@woile
Copy link
Member

woile commented Sep 5, 2025

Ok, let's give it a go then. Can you rebase @vemilano ? 🙏🏻

@vemilano vemilano force-pushed the fix/cargo-workspaces branch from 05ecc06 to f0bdea5 Compare September 5, 2025 16:12
@woile woile merged commit 1cde9ee into commitizen-tools:master Sep 5, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong handling of cargo workspaces

3 participants