-
Notifications
You must be signed in to change notification settings - Fork 933
Update release.md to remove outdated info and deprecated links #2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -166,7 +166,13 @@ reviewed by team mates, perform one or more CANDIDATE ITERATION, and then do a | |||||
| final RELEASE ITERATION. | ||||||
|
|
||||||
|
|
||||||
| ### 5.1. Create a tag | ||||||
| ### 5.1. Push the RC branch | ||||||
|
|
||||||
| Push your branch: | ||||||
| $ git push origin v0.11.4rc | ||||||
|
|
||||||
|
|
||||||
| ### 5.2. Create a tag | ||||||
|
|
||||||
| Packaging is fragile and is only triggered when a tag is pushed. To avoid | ||||||
| finding out about packaging problems on the RC tag, it is strongly recommended | ||||||
|
|
@@ -179,49 +185,17 @@ be removed after the build passes. | |||||
| That is to say that while the librdkafka RC is named `v0.11.4-RC3` | ||||||
| a Python client RC with the same version is named `v0.11.4rc3`. | ||||||
|
|
||||||
| **TEST ITERATION**: | ||||||
|
|
||||||
| # Repeat with new tags until all build issues are solved. | ||||||
| $ git tag v0.11.4rc1-dev2 | ||||||
|
|
||||||
| # Delete any previous test tag you've created. | ||||||
| $ git tag tag -d v0.11.4rc1-dev1 | ||||||
|
|
||||||
|
|
||||||
| **CANDIDATE ITERATION**: | ||||||
|
|
||||||
| $ git tag v0.11.4rc1 | ||||||
|
|
||||||
|
|
||||||
| **RELEASE ITERATION**: | ||||||
|
|
||||||
| $ git tag v0.11.4 | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
| ### 5.2. Push tag and commits | ||||||
|
|
||||||
| Perform a dry-run push first to make sure the correct branch and only our tag | ||||||
| is pushed. | ||||||
|
|
||||||
| $ git push --dry-run --tags origin v0.11.4rc # tags and branch | ||||||
|
|
||||||
| An alternative is to push branch and tags separately: | ||||||
|
|
||||||
| $ git push --dry-run origin v0.11.4rc # the branch | ||||||
| $ git push --dry-run origin v0.11.4rc1 # the tag | ||||||
|
|
||||||
|
|
||||||
| Verify that the output corresponds to what you actually wanted to push; | ||||||
| the correct branch and tag, etc. | ||||||
|
|
||||||
| Remove `--dry-run` when you're happy with the results. | ||||||
| Use the [Semaphore CI tag-release task](https://semaphore.ci.confluent.io/projects/clients-releases/schedulers/30e1eb9a-91de-43a4-a8de-be4f3de5a3b6) to create tags. Set the parameter accordingly: | ||||||
| - **PROJECT**: confluent-kafka-python | ||||||
| - **GIT_REF**: name of your RC branch (`v0.11.4rc` in this tutorial) | ||||||
| - **TAG_NAME**: name of the new tag (`v0.11.4rc1-dev1`, for example) | ||||||
| - You can do a test run (set **dry_run** to true) to verify the output before proceeding with the actual tag creation (set **dry_run** to true). | ||||||
|
|
||||||
|
|
||||||
| ### 5.3. Wait for CI builds to complete | ||||||
|
|
||||||
| Monitor Semaphore CI builds by looking at the *tag* build at | ||||||
| [Semaphore CI](https://confluentinc.semaphoreci.com/projects/confluent-kafka-python) | ||||||
| [Semaphore CI](https://semaphore.ci.confluent.io/projects/confluent-kafka-python) | ||||||
|
|
||||||
| CI jobs are flaky and may fail temporarily. If you see a temporary build error, | ||||||
| e.g., a timeout, restart the specific job. | ||||||
|
|
@@ -232,11 +206,11 @@ and push a new test tag. Don't forget to delete your previous test tag. | |||||
|
|
||||||
| ### 5.4. Download build artifacts | ||||||
|
|
||||||
| When all CI builds are successful it is time to download the resulting | ||||||
| artifacts from build's Artifact directory located in another tab in the build: | ||||||
| When all CI builds are successful it is time to download all the resulting | ||||||
| artifacts (wheels) from build's `artifacts` directory (located in the `Artifacts` tab in the build). | ||||||
|
|
||||||
| Create a new folder `tools\dl-<tag>` under the repository root, and unzip all artifacts from the downloaded .tgz files there. You should have many artifacts (with .whl suffix) under `tools\dl-<tag>` as we support different operating systems and Python versions. | ||||||
|
||||||
| Create a new folder `tools\dl-<tag>` under the repository root, and unzip all artifacts from the downloaded .tgz files there. You should have many artifacts (with .whl suffix) under `tools\dl-<tag>` as we support different operating systems and Python versions. | |
| Create a new folder `tools/dl-<tag>` under the repository root, and unzip all artifacts from the downloaded .tgz files there. You should have many artifacts (with .whl suffix) under `tools/dl-<tag>` as we support different operating systems and Python versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the pip install -i https://test.pypi.org/simple/ "confluent-kafka==<RELEASE.VERSION>" pip install --no-binary "confluent-kafka" -i https://test.pypi.org/simple/ "confluent-kafka==<RELEASE.VERSION>" to the verify section here. We've had two releases recently where the source install path got messed up by typo and didn't get caught that this ensures is checked. You'll need to note that on OSX you need the lib and bin path for librdkafka set as indicated earlier in the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'set dry_run to true' is repeated twice in the same sentence. This appears to be a copy-paste error. Consider revising to: 'You can do a test run (set dry_run to true) to verify the output before proceeding with the actual tag creation (set dry_run to false).'