Added Helm chart #440
Added Helm chart #440
Conversation
Signed-off-by: Andrew Block <andy.block@gmail.com>
Cali0707
left a comment
Cali0707
left a comment
There was a problem hiding this comment.
Thanks for adding the helm chart @sabre1041 !
Have a few questions/comments but overall this looks great!!
| {{- with .Values.extraVolumeMounts }} | ||
| {{- tpl (toYaml .) . | nindent 12 }} | ||
| {{- end }} | ||
| {{- with .Values.extraVolumeMounts }} | ||
| {{- tpl (toYaml .) . | nindent 12 }} | ||
| {{- end }} |
| registry: quay.io | ||
| repository: manusa/kubernetes_mcp_server | ||
| # -- This sets the tag or sha digest for the image. | ||
| version: latest |
There was a problem hiding this comment.
should this go to latest? or do we want to pin it to the most recent release?
There was a problem hiding this comment.
I think generally, we should have image somewhere else published, instead of manusa repo 😅
| annotations: | ||
| {{- tpl (toYaml .) . | nindent 4 }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
@sabre1041 maybe I'm missing something but don't we need a ClusterRole + ClusterRoleBinding if require_oauth is not set to true (false is the default)?
There was a problem hiding this comment.
In this scenario, if a request does not have a bearer token in the request, the underlying kubernetes manager will be used (using the service account credentials), which has no permissions
4 participants
Added a Helm chart for the MCP Server
Future enhancements include automating the publishing of the chart to an OCI repository
resolves #435