(hold-merge-with-along-go-sdk) Remove deprecated http/sse port from cli #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
force-pushed
the
remove_deprecated_flags
branch
from
43abd92 to
7272899
Compare
Member
|
/hold |
manusa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI still has the deprecated flags for
http/sseport. Removing just those deprecated flags since we are close to migrate to new SDK.I guess somewhat related, and likely different issue, but isn't the SSE transport is deprecated? Or is that being tackled with the migration to the new, "official", SDK, @manusa ?