refactor: include op-patch from json-patch #2823
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch as regualr dependency for typescript projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state of the new-beta branch, typescript projects using the new beta would complain about the missing dependency, as it won't be installed there as a devDependency.
I chose in my variant to include it simply as a regular dependency and continue, but I felt now it might be better to include that one type we use everywhere in our own project, avoiding having this dependency + types completely.
See: https://github.com/contentful/contentful-management.js/blob/beta/package.json#L81
Just a suggestion, but we need that type available for projects similar to https://github.com/axe312ger/contentful-compatibility-cda/tree/main/environments/node-ts-mjs