fixed #14276 - report inline suppressions with invalid error IDs #7970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
force-pushed
the
bad-inline
branch
4 times, most recently
from
1c49605 to
ac64111
Compare
Collaborator
Author
|
Still fails tests because as inline suppressions are now being tracked globally until the end of the analysis ones that are found in included filed might be picked up more than once. To fix this the function adding the suppressions should report more states than boolean and using the fileindex we can determine that it isn't the file which passed to the analysis and omit the warning. That would probably cause suppressions which are duplicated in the included file itself never to be reported (need to add tests for that) - but that seems acceptable for now. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.