Skip to content

Conversation

@goderbauer
Copy link
Contributor

Clean-up: Since FFIgen generates a blanket ignore_for_file: type=lint most of these specific ignores are not necessary. Let's remove them to avoid confusion and stop them from getting cargo-culted everywhere.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

PR Health

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@goderbauer goderbauer changed the title [swiftgen] clean up unnecessary 'ignore_for_file's [swiftgen] clean up unnecessary ignore_for_files Nov 6, 2025
@coveralls
Copy link

Coverage Status

coverage: 81.971%. remained the same
when pulling e682d08 on goderbauer:ignore_swiftgen
into d6e6a06 on dart-lang:main.

@goderbauer goderbauer merged commit 28b7c5f into dart-lang:main Nov 11, 2025
15 checks passed
@goderbauer goderbauer deleted the ignore_swiftgen branch November 11, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants