Skip to content

BUG: fix sign(0+0j) to be zero, not nan #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: fix sign(0+0j) to be zero, not nan #172

wants to merge 1 commit into from

Conversation

@ev-br
Copy link
Member

@ev-br ev-br commented Nov 30, 2025

closes gh-166

@ev-br ev-br added this to the 2.5 milestone Nov 30, 2025
@ev-br ev-br added the bug Something isn't working label Nov 30, 2025
@ev-br ev-br mentioned this pull request Nov 30, 2025
Open
@ev-br ev-br closed this Dec 2, 2025
@ev-br ev-br reopened this Dec 2, 2025
@ev-br
Copy link
Member Author

ev-br commented Dec 2, 2025 

$ ARRAY_API_TESTS_MODULE=array_api_strict pytest array_api_tests/test_operators_and_elementwise_functions.py::test_sign -v --max-examples 10_000

passes locally for me with 10_000 examples under numpy 1.26.4 (which needs an additional workaround for single-precision values) and numpy 2.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

2.5

Development

Successfully merging this pull request may close these issues.

sign of complex 0+0j returns complex nan

1 participant

@ev-br