Skip to content

fix(query): handle complex types in procedure argument parsing #18929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(query): handle complex types in procedure argument parsing #18929

wants to merge 2 commits into from

Conversation

@TCeason
Copy link
Collaborator

@TCeason TCeason commented Nov 6, 2025 •
edited
Loading

Fixed procedure argument type parsing to correctly handle types with nested parentheses like Decimal(4, 2).

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Fixed procedure argument type parsing to correctly handle complex types with parentheses (e.g., Decimal(4, 2))

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason
fix(query): handle complex types in procedure argument parsing
681dead 
Fixed procedure argument type parsing to correctly handle types with
nested parentheses like Decimal(4, 2).
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 6, 2025
@TCeason TCeason requested a review from sundy-li November 6, 2025 02:43
@TCeason
refactor(ast): use Vec<TypeName> in ProcedureIdentity instead of String
b465ed1 
This change improves type safety by preserving TypeName information
from the parser to the binder, avoiding unnecessary string round-trip
conversions when handling complex types like Decimal(4, 2).
@TCeason TCeason force-pushed the fix-decimal-procedure-arg branch from 9f5783e to b465ed1 Compare November 6, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sundy-li sundy-li Awaiting requested review from sundy-li

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TCeason