Skip to content

feat(search): Add canViewEntityPage permission flag field to search results #15183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

feat(search): Add canViewEntityPage permission flag field to search results #15183

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b5a2cf9
feat(search): Add canViewEntityPage permission flag field to search r…
Nov 3, 2025
40636a0
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 3, 2025
84796a0
linter happy
Nov 3, 2025
ee88f39
add canViewEntityPage value to mocks
Nov 3, 2025
fc59572
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 3, 2025
a3d3b79
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 3, 2025
2c60dbc
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 4, 2025
5d7acba
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 4, 2025
1417701
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 4, 2025
4a3a60c
boost test coverage for MapperUtils
Nov 4, 2025
4271055
linter green for MapperUtilsTest
Nov 4, 2025
74877af
address PR feeback to remove canViewEntityPage into extraProperties
Nov 10, 2025
8f85c9c
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 10, 2025
cb15a10
update Mocks.tsx and clean up MapperUtilsText
Nov 10, 2025
005d1dd
linter happy
Nov 10, 2025
8a70373
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 10, 2025
f73ba0c
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 11, 2025
0b4d995
add canViewEntityPage to EntityPrivileges
Nov 12, 2025
540d505
cleanup
Nov 12, 2025
d04ba64
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 12, 2025
3f10e02
test cases for EntityPrivilegesResolver
Nov 12, 2025
a45ca27
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 13, 2025
fedbe6e
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 20, 2025
79341e2
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 21, 2025
85d5e6f
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 22, 2025
eab03ba
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 25, 2025
b187bc4
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 25, 2025
0f60ac1
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 25, 2025
c6048c7
Merge branch 'master' into esimplicity-copilot/search-entity-page-vie…
yorubaphenom Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 155 additions & 1 deletion datahub-web-react/src/Mocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2335,6 +2335,13 @@ export const mocks = [
entity: {
...dataset1,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [
{
name: 'fieldName',
Expand All @@ -2347,12 +2354,26 @@ export const mocks = [
entity: {
...dataset2,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
},
{
entity: {
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
},
],
facets: [
Expand Down Expand Up @@ -2428,6 +2449,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -2500,6 +2528,13 @@ export const mocks = [
__typename: 'GLOSSARY_TERM',
...glossaryTerm1,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -2608,6 +2643,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -2782,6 +2824,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -2851,6 +2900,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand All @@ -2859,6 +2915,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset4,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -2928,6 +2991,13 @@ export const mocks = [
__typename: 'DataFlow',
...dataFlow1,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -3074,6 +3144,13 @@ export const mocks = [
__typename: 'DataJob',
...dataJob1,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -3170,6 +3247,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -3290,6 +3374,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -3340,6 +3431,13 @@ export const mocks = [
__typename: 'DataJob',
...dataJob1,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -3417,6 +3515,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -3499,6 +3604,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand All @@ -3507,6 +3619,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset4,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -3596,6 +3715,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -3689,6 +3815,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -3960,6 +4093,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset3,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand All @@ -3968,6 +4108,13 @@ export const mocks = [
__typename: 'Dataset',
...dataset4,
},
extraProperties: [
{
name: 'canViewEntityPage',
value: 'true',
__typename: 'ExtraProperty',
},
],
matchedFields: [],
insights: [],
},
Expand Down Expand Up @@ -4366,6 +4513,7 @@ export const mockSearchResult: SearchResult = {
matchedFields: [],
insights: [],
extraProperties: [
{ name: 'canViewEntityPage', value: 'true', __typename: 'ExtraProperty' },
{ name: 'isOutputPort', value: 'true' },
{ name: 'test2_name', value: 'test2_value' },
],
Expand All @@ -4388,7 +4536,13 @@ export const mockFineGrainedLineages1: GenericEntityProperties = {
siblingsSearch: {
count: 1,
total: 1,
searchResults: [{ entity: { type: EntityType.Dataset, urn: 'test_urn' }, matchedFields: [] }],
searchResults: [
{
entity: { type: EntityType.Dataset, urn: 'test_urn' },
matchedFields: [],
extraProperties: [{ name: 'canViewEntityPage', value: 'true', __typename: 'ExtraProperty' }],
},
],
},
fineGrainedLineages: [
{
Expand Down
1 change: 1 addition & 0 deletions datahub-web-react/src/app/entity/shared/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,4 +208,5 @@ export type RequiredAndNotNull<T> = {
export type EntityAndType = {
urn: string;
type: EntityType;
canViewEntityPage?: boolean | null;
};
4 changes: 4 additions & 0 deletions datahub-web-react/src/graphql/search.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,6 +1302,10 @@ fragment searchResults on SearchResults {
text
icon
}
extraProperties {
name
value
}
}
facets {
...facetFields
Expand Down
Loading
Loading