Skip to content

fix(logs): Warn instead of error on schema extract failure #15230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinkarchacryl merged 5 commits into from
Nov 13, 2025
Merged

fix(logs): Warn instead of error on schema extract failure #15230

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2655f4
fix(logs): Warn instead of error on schema extract failure
kevinkarchacryl Nov 6, 2025
9d81245
Update metadata-ingestion/src/datahub/ingestion/source/s3/source.py
kevinkarchacryl Nov 12, 2025
d0992eb
fix error with missing e
kevinkarchacryl Nov 12, 2025
952f4e6
Merge branch 'master' into warn-s3-no-schema-extract
kevinkarchacryl Nov 12, 2025
42e6b82
Merge branch 'master' into warn-s3-no-schema-extract
kevinkarchacryl Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/s3/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,8 +735,11 @@ def ingest_table(
)
aspects.append(schema_metadata)
except Exception as e:
logger.error(
f"Failed to extract schema from file {table_data.full_path}. The error was:{e}"
self.report.report_warning(
title="Failed to extract schema from file",
message="Schema may be missed for dataset because of failure when extracting schema from file",
context=f"dataset={table_data.display_name}, file={table_data.full_path}",
exc=e,
)
else:
logger.info(
Expand Down
Loading