Skip to content

Conversation

@purnimagarg1
Copy link
Collaborator

Linear ticket:
https://linear.app/acryl-data/issue/CAT-905/build-skeleton-for-dataset-summary-page

Description:

This PR adds summary page for dataset assets with the common skeleton of Properties and About sections.
Summary tab is visible and Documentation tab is hidden on dataset entities currently under the feature flag datasetSummaryPageV1

Screenshots:

image

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 7, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...b/graphql/types/dataset/mappers/DatasetMapper.java 50.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Nov 7, 2025

✅ Meticulous spotted visual differences in 3 of 939 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 73658e0. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Bundle Report

Changes will increase total bundle size by 309 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.63MB 309 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 309 bytes 19.0MB 0.0%

Files in assets/index-*.js:

  • ./src/app/entityV2/dataset/DatasetEntity.tsx → Total Size: 13.66kB

  • ./src/app/entityV2/summary/properties/hooks/useBasicAssetProperties.ts → Total Size: 807 bytes

  • ./src/app/homeV3/context/hooks/utils/utils.ts → Total Size: 1.9kB

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@chriscollins3456 chriscollins3456 merged commit 84fe389 into master Nov 10, 2025
76 checks passed
@chriscollins3456 chriscollins3456 deleted the pg--cat-905-dataset-summary-page branch November 10, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants