-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(dataset-summary): add summary tab on dataset entities #15238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
✅ Meticulous spotted visual differences in 3 of 939 screens tested, but all differences have already been approved: view differences detected. Meticulous evaluated ~9 hours of user flows against your PR. Last updated for commit 73658e0. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 309 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
chriscollins3456
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Linear ticket:
https://linear.app/acryl-data/issue/CAT-905/build-skeleton-for-dataset-summary-page
Description:
This PR adds summary page for dataset assets with the common skeleton of Properties and About sections.
Summary tab is visible and Documentation tab is hidden on dataset entities currently under the feature flag
datasetSummaryPageV1Screenshots: