-
Notifications
You must be signed in to change notification settings - Fork 4
chore(deps): update definitelytyped #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughBumps TypeScript declaration package versions in package.json: Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
Comment |
|
e7995d7 to
b6fd35b
Compare
b6fd35b to
136521d
Compare
136521d to
c44d7c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
324357d to
b43aa9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
src/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
package.json
[error] 1-1: Command failed with exit code 1: npm ci --prefer-offline --no-audit
b71a11c to
2b76688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
src/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
2276-2276: Clarify @types/temp vs runtime tmp package.Line 2276 references
@types/temp@^0.9.0, but the runtime dependency istmp@^0.2.4(line 2218). Verify these refer to the same package or clarify the intent.
3ba1ac3 to
68e1475
Compare
6ac6f61 to
ce9bd10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (2)
package.json (2)
2590-2590: No active codebase usage detected for react-json-treeSearches found no imports or component usage in the codebase. If this package is only a transitive dependency or not actively used, the version bump poses no compatibility risk. Verify manually that this dependency serves a purpose and check the DefinitelyTyped changelog if direct usage exists.
2586-2586: @types/pdfkit mismatch: types v0.17.0 but pdfkit runtime is v0.13.0pdfkit is used in
src/webviews/extension-side/plotting/plotViewer.node.ts(lines 71–81). The types version (0.17.0) is ahead of the runtime (0.13.0)—types should be backward compatible, but verify the types work correctly with the runtime version and that the basic pdfkit constructor and SVGtoPDF integration have no issues.
ce9bd10 to
9accfc4
Compare
6e2b641 to
81e1715
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
81e1715 to
a875b41
Compare
a875b41 to
7997517
Compare
306d6e5 to
9e35723
Compare
9e35723 to
b3d3f13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
| "@types/node": "^22.15.1", | ||
| "@types/node-fetch": "^2.6.12", | ||
| "@types/pdfkit": "^0.11.0", | ||
| "@types/pdfkit": "^0.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Package.json specifies four updated @types packages but package-lock.json is absent from this PR or remains out of sync. This will cause npm ci to fail. Run npm install --package-lock-only locally, verify all four packages appear in the lockfile with matching versions, then commit the updated package-lock.json.
Also applies to: 2590-2590, 2597-2597, 2601-2601
🏁 Script executed:
#!/bin/bash
# Verify package-lock.json sync after regeneration
if [ -f package-lock.json ]; then
echo "=== Checking package-lock.json for four updated @types ==="
jq '.packages[] | select(.name | test("@types/(pdfkit|react-json-tree|stack-trace|temp)")) | "\(.name): \(.version)"' package-lock.json 2>/dev/null | sort
echo ""
echo "=== Corresponding devDependencies in package.json ==="
jq '.devDependencies | to_entries[] | select(.key | test("@types/(pdfkit|react-json-tree|stack-trace|temp)")) | "\(.key): \(.value)"' package.json 2>/dev/null | sort
echo ""
echo "=== Testing npm ci would pass ==="
npm ci --dry-run 2>&1 | head -20 || echo "npm ci check failed"
else
echo "package-lock.json not found in repository"
fiLength of output: 1070
Lockfile out of sync—package-lock.json missing four @types entries.
The four updated @types packages (pdfkit, react-json-tree, stack-trace, temp) appear in package.json but not in package-lock.json. Regenerate the lockfile by running npm install --package-lock-only and commit the updated package-lock.json.
🤖 Prompt for AI Agents
In package.json around line 2586, four updated @types entries (@types/pdfkit,
@types/react-json-tree, @types/stack-trace, @types/temp) were added to
package.json but not reflected in package-lock.json; run npm install
--package-lock-only at the repo root to regenerate the lockfile so those entries
are included, verify package-lock.json changes, and commit the updated
package-lock.json to the branch.
This PR contains the following updates:
4.3.6->4.3.202.0.1->2.0.37.1.6->7.1.82.8.12->2.8.194.1.7->4.1.120.7.0->0.7.24.0.0->4.0.31.0.2->1.0.45.0.37->5.0.385.0.3->5.0.75.13.4->5.13.104.14.181->4.17.2018.19.31->18.19.13022.15.31->22.19.02.6.12->2.6.13^0.11.0->^0.17.00.4.0->0.4.316.9.14->16.9.25^0.6.8->^0.13.07.1.23->7.1.349.21.20->9.22.33.0.9->3.0.1310.0.15->10.0.200.0.29->0.0.332.0.1->2.0.40.1.0->0.1.31.0.1->1.0.4^0.8.32->^0.9.00.2.3->0.2.61.4.8->1.4.111.88.0->1.105.01.60.0->1.72.4Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.