Skip to content

chore: Use .nvmrc for Node version in CI/CD workflows and npm install in post-checkout hook #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 21, 2025
Merged

chore: Use .nvmrc for Node version in CI/CD workflows and npm install in post-checkout hook #92

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5b1ad6
Use .nvmrc for Node version in CI/CD workflows and npm install in pos…
devin-ai-integration[bot] Oct 20, 2025
f56b0ec
Merge branch 'main' into devin/1760981665-use-nvmrc-in-workflows
jamesbhobbs Oct 20, 2025
e40fffb
Update npm ci to npm install everywhere except CI workflow files
devin-ai-integration[bot] Oct 20, 2025
9537ee1
Revert workflow files back to npm ci
devin-ai-integration[bot] Oct 20, 2025
c7f7cbb
Revert GitHub actions and Azure pipelines back to npm ci
devin-ai-integration[bot] Oct 21, 2025
d597dd0
Merge branch 'main' into devin/1760981665-use-nvmrc-in-workflows
jamesbhobbs Oct 21, 2025
2419d9f
Update CONTRIBUTING.md to use npm install for local development
devin-ai-integration[bot] Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/dev-with-python/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

"mounts": ["source=${localWorkspaceFolder},target=/workspaces/local,type=bind,consistency=cached"],
// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "npm ci",
// "postCreateCommand": "npm install",
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
"remoteUser": "vscode"
}
2 changes: 1 addition & 1 deletion .devcontainer/dev/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
},
"mounts": ["source=${localWorkspaceFolder},target=/workspaces/local,type=bind,consistency=cached"]
// Use 'postCreateCommand' to run commands after the container is created.
// "postCreateCommand": "npm ci",
// "postCreateCommand": "npm install",
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
// , "remoteUser": "vscode"
}
17 changes: 7 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ on:
branches: [main]
workflow_dispatch:

env:
NODE_VERSION: 22.x

permissions:
actions: read
contents: read
Expand All @@ -32,7 +29,7 @@ jobs:
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand All @@ -59,7 +56,7 @@ jobs:
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand Down Expand Up @@ -107,7 +104,7 @@ jobs:
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand Down Expand Up @@ -157,7 +154,7 @@ jobs:
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand All @@ -181,7 +178,7 @@ jobs:
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand All @@ -205,7 +202,7 @@ jobs:
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand All @@ -229,7 +226,7 @@ jobs:
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/copilot-setup-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ on:
- .github/workflows/copilot-setup-steps.yml

env:
NODE_VERSION: 22.15.1
NPM_VERSION: 10.9.2
PYTHON_VERSION: 3.12
DENO_VERSION: '~1.37'
Expand Down Expand Up @@ -42,7 +41,7 @@ jobs:
- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
node-version: ${{env.NODE_VERSION}}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ on:
- cron: '0 9 * * 1'
workflow_dispatch:

env:
NODE_VERSION: 22.x

permissions:
actions: read
contents: read
Expand All @@ -30,7 +27,7 @@ jobs:
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand Down Expand Up @@ -62,7 +59,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
cache: 'npm'

- name: Install dependencies
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ on:
branches: [main]
workflow_dispatch:

env:
NODE_VERSION: 22.x

permissions:
contents: read
packages: read
Expand All @@ -31,7 +28,7 @@ jobs:
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
with:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}
node-version-file: '.nvmrc'
registry-url: 'https://npm.pkg.github.com'
scope: '@deepnote'

Expand Down
2 changes: 1 addition & 1 deletion .husky/post-checkout
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
npm ci
npm install