Skip to content

Conversation

@dfokina
Copy link
Contributor

@dfokina dfokina commented Nov 6, 2025

Related Issues

Proposed Changes:

  • Add image input examples to 13 Chat Generator docs pages

How did you test it?

Verified snippets manually

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@dfokina dfokina requested a review from a team as a code owner November 6, 2025 17:49
@dfokina dfokina requested review from mpangrazzi and removed request for a team November 6, 2025 17:49
@dfokina dfokina added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Nov 6, 2025
@vercel
Copy link

vercel bot commented Nov 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
haystack-docs Ready Ready Preview Comment Nov 10, 2025 4:29pm

@dfokina dfokina requested review from anakin87 and removed request for mpangrazzi November 10, 2025 14:50
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

Co-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>
@dfokina
Copy link
Contributor Author

dfokina commented Nov 10, 2025

@anakin87 thanks for the notes! I standardized all examples to the same format

@dfokina dfokina requested a review from anakin87 November 10, 2025 16:28
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dfokina dfokina merged commit 27355ba into main Nov 10, 2025
11 checks passed
@dfokina dfokina deleted the image-input-code-snippets branch November 10, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add image input examples to Haystack docs for Chat Generators

3 participants