Fixing common-utils fails when existing user’s primary group name differs from username #1521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing #1514
Issue:
The common-utils feature was failing with groupadd: GID '100' already exists and usermod: UID '1000' already exists errors when trying to create users with GID 100 or modify existing users with conflicting UIDs.
Root Cause:
GID 100 is typically reserved for the users group in most Linux distributions
The script attempted to create new groups with existing GIDs without checking if they already exist
UID conflicts occurred when trying to modify users to UIDs already in use by other users
Changes Made:
Purpose: Properly detect existing group names for users instead of assuming the group name matches the username.
Purpose: Use existing groups (like users with GID 100) instead of failing when trying to create them.
Purpose: Prevent UID conflicts by checking if the target UID is already in use by another user.
Purpose: Test the specific case where GID 100 is requested to ensure the feature handles it gracefully.
Checklist:
Changes worked as expected.