-
Notifications
You must be signed in to change notification settings - Fork 42
refactor: migrate from XState to Zustand for state management #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vgeorge
wants to merge
7
commits into
main
Choose a base branch
from
refactor/xstate-to-zustand
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
129ee39
refactor: migrate from XState to Zustand for state management
vgeorge 19142c4
test: refactor and organize UI tests for XState to Zustand migration
vgeorge b82a9a0
refactor: clean up code and improve test organization for Zustand mig…
vgeorge 8006de1
refactor: improve state management organization and documentation
vgeorge 2ada35f
feat: increate test coverage to include tooltip hover
vgeorge a862d25
Merge branch 'main' into refactor/xstate-to-zustand
vgeorge f74b0c1
Update src/state/index.ts
vgeorge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import { GeoArrowPickingInfo } from "@geoarrow/deck.gl-layers"; | ||
| import { create } from "zustand"; | ||
|
|
||
| interface AppState { | ||
| highlightedFeature: GeoArrowPickingInfo | undefined; | ||
| setHighlightedFeature: (feature: GeoArrowPickingInfo | undefined) => void; | ||
| bboxSelectStart: number[] | undefined; | ||
| bboxSelectEnd: number[] | undefined; | ||
| isDrawingBbox: boolean; | ||
| startBboxSelection: () => void; | ||
| cancelBboxSelection: () => void; | ||
| clearBboxSelection: () => void; | ||
| setBboxStart: (coordinate: number[]) => void; | ||
| setBboxEnd: (coordinate: number[]) => void; | ||
| setBboxHover: (coordinate: number[]) => void; | ||
| } | ||
|
|
||
| export const useStore = create<AppState>((set) => ({ | ||
| highlightedFeature: undefined, | ||
| setHighlightedFeature: (feature) => set({ highlightedFeature: feature }), | ||
| bboxSelectStart: undefined, | ||
| bboxSelectEnd: undefined, | ||
| isDrawingBbox: false, | ||
| startBboxSelection: () => | ||
| set({ | ||
| isDrawingBbox: true, | ||
| bboxSelectStart: undefined, | ||
| bboxSelectEnd: undefined, | ||
| }), | ||
| cancelBboxSelection: () => | ||
| set({ | ||
| isDrawingBbox: false, | ||
| bboxSelectStart: undefined, | ||
| bboxSelectEnd: undefined, | ||
| }), | ||
| clearBboxSelection: () => | ||
| set({ bboxSelectStart: undefined, bboxSelectEnd: undefined }), | ||
| setBboxStart: (coordinate) => set({ bboxSelectStart: coordinate }), | ||
| setBboxEnd: (coordinate) => | ||
| set((state) => { | ||
| // Only finish drawing if a start point has been set | ||
| if (state.bboxSelectStart) { | ||
| return { bboxSelectEnd: coordinate, isDrawingBbox: false }; | ||
| } | ||
| return {}; | ||
| }), | ||
| setBboxHover: (coordinate) => | ||
| set((state) => { | ||
| // Only update hover if we're drawing and have a start point | ||
| if (state.isDrawingBbox && state.bboxSelectStart) { | ||
| return { bboxSelectEnd: coordinate }; | ||
| } | ||
| return {}; | ||
| }), | ||
| })); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can always be set on
bboxProps. The canonical way to toggle visibility is with the layer'svisibleprop. So we can setvisible: falsein general and then