chore: refactor controller #185
Conversation
|
the operator code is so much coupled. Part of it is kind-of related to operator-sdk not providing any framework or abstractions for building operator resources. I'll be creating some abstractions in a separate repo to act as a base for operator builders. This is a lot of work but is something that is crucial and needed for the community. |
|
running them will result in the following changes: 
|
| return false, nil | ||
| } | ||
| func (p Peers) getPeerConfig(peer v1alpha1.WireguardPeer) string { | ||
| cfg := fmt.Sprintf(` |
There was a problem hiding this comment.
I wonder if we should actually encode real object instead of string formatting. We wouldn't do this for yaml or json, so why from toml?
Hypothetically:
type WireguardConfiguration struct {
Interface WireguardInterfaceConfiguration
// ...
}
type WireguardInterfaceConfiguration struct {
PrivateKey string
Address string
DNS string
}
b, err := toml.Marshal(WireguardConfiguration{
Interface: WireguardInterfaceConfiguration{
PrivateKey: fmt.Sprintf("$(kubectl get secret %s-peer --template={{.data.privateKey}} -n %s | base64 -d)", peer.Name, peer.Namespace),
Address: peer.Spec.Address
DNS: p.constructDnsConfig()
},
})
// ...
| if !bytes.Equal(expectedSecret.Data["state.json"], secret.Data["state.json"]) { | ||
| return true, nil | ||
|
|
||
| } | ||
|
|
||
| return false, nil |
There was a problem hiding this comment.
| if !bytes.Equal(expectedSecret.Data["state.json"], secret.Data["state.json"]) { | |
| return true, nil | |
| } | |
| return false, nil | |
| return !bytes.Equal(expectedSecret.Data["state.json"], secret.Data["state.json"]), nil |
| } else if err == nil { | ||
| privateKey = string(sec.Data["privateKey"]) | ||
| publicKey = string(sec.Data["publicKey"]) |
There was a problem hiding this comment.
This should be moved, as everything after the if err != nil line matches this condition
| @@ -0,0 +1,176 @@ | |||
| package resources | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
needs formatting (gofmt -s -w .)
| } | ||
|
|
||
| func (s Service) GetAddressAndPort(ctx context.Context) (string, string, error) { | ||
| var port = fmt.Sprintf("%d", s.TargetPort) |
There was a problem hiding this comment.
| var port = fmt.Sprintf("%d", s.TargetPort) | |
| port := strconv.Itoa(s.TargetPort) |
first steps to fix #171