Skip to content

Conversation

@joe-explr
Copy link

@joe-explr joe-explr commented Nov 19, 2025

Summary of Changes:

  • Created a new files: put_with_notify.c.in, get_with_notify.c.in. to enable a public api for put_with_notify and get_with_notify.
  • Added OMPI_SPC_GET_WITH_NOTIFY, OMPI_SPC_PUT_WITH_NOTIFY enum to track call counts.
  • Added 'MPI_ERR_NOTIFY_IDX' to error out invalid notification_idx value.
  • Edited mpi.h.in to add definitions for the ERROR and the operation signature.

@github-actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

8d7ea3b: Public APis to makefile

  • check_signed_off: does not contain a valid Signed-off-by line

0b6b3c3: Public APIs for put_withnotify. get_with_notify

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@joe-explr joe-explr force-pushed the notified-rma-sm branch 3 times, most recently from 5a9c010 to f79b94b Compare November 19, 2025 19:28
	put_with_notify
	get_with_notify

Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
@github-actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

8ba738e: Edits

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

'MPI_ERR_VALUE_TOO_LARGE': 79,
'MPI_ERR_ERRHANDLER': 80,
'MPI_ERR_LASTCODE': 92,
'MPI_ERR_NOTIFY_IDX': 81,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go before MPI_ERR_LASTCODE.

#include "ompi/datatype/ompi_datatype.h"
#include "ompi/runtime/ompi_spc.h"

PROTOTYPE ERROR_CLASS get_with_notify(BUFFER_OUT origin_addr, COUNT origin_count,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be consistent with the proposal (get_notify).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants