test: normalize XML before comparison to avoid attribute-order failures #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR makes XML comparisons in tests deterministic by normalizing attribute order before asserting equality.
When running tests under NonDex, XML attributes may appear in different orders, causing false test failures even though the XML content is equivalent. This is likely due to the use of a hashMap in
completeState()inEclipseApp.javawhenis used to build the XML string, and the use of hashMaps in
mirrorAppinP2Model.javafrom calling
.attributes(), as HashMaps do not guarantee the order of key value pairs over time.This class is confirmed when adding the following lines to
mirrorApp:This change ensures the XML tests fail only when there is a real XML mismatch, not due to nondeterministic attribute ordering.
What the PR changes
with
normalizeXmltoCleanedAssert.java, which:This ensures that
and
are treated as equal in tests
Results
Steps to reproduce original Failure
pluginsinbuild.gradle:id 'edu.illinois.nondex' version '2.1.7'build.gradle:apply plugin: 'edu.illinois.nondex'to
./gradlew nondexTest --tests "com.diffplug.gradle.p2.P2ModelTest.testMirrorAntFile",./gradlew nondexTest --tests "com.diffplug.gradle.p2.P2ModelTest.testMirrorAntFileWithAppend",./gradlew nondexTest --tests "com.diffplug.gradle.p2.P2ModelTest.testMirrorAntFileWithAppenDefault",and
./gradlew nondexTest --tests "com.diffplug.gradle.p2.P2ModelTest.testMirrorAntFileWithSlicingOptions"in the terminal